Smashing bugs and moving full system prompts and stance system to markdown - #13
Merged
Conversation
Contributor
Qodana Community for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.1.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Ronin settings system to simplify stance management and configuration, and introduces improvements to how stances are loaded and parsed. It removes several stance-related fields from the global settings and user interface, instead loading stance definitions from Markdown files in a resource directory. Additionally, it adds better handling for command execution cancellation in the chat UI.
The most important changes are:
Stance Loading and Parsing Improvements:
/stancesresource directory, supporting both file and JAR resource loading. TheRoninSettingsStateclass includes new logic to parse these files and extract stance configuration and system prompts, replacing the previous JSON-based approach.parseStanceMarkdownmethod is introduced to extract stance metadata and system prompts from Markdown frontmatter, supporting a more modular and maintainable stance definition format.Settings and UI Simplification:
Stancedata class and the settings UI:scope,executionCommand, andallowedTools. ThecoreWorkflowfield is also removed from global settings. The settings UI and form logic are updated accordingly, reducing complexity and potential for user error. [1] [2] [3] [4] [5] [6] [7] [8]LLMServiceImpl.sendMessageis replaced with the stance's own prompt.Chat UI/Command Execution Improvements:
Futurereference is now kept for the currently running command, allowing for better management and potential cancellation of command execution. The UI now checks if generation was cancelled before proceeding with follow-up actions, preventing unwanted outputs if a command is stopped. [1] [2] [3]Minor Cleanups:
LLMServiceImpl.These changes make stance management more maintainable and flexible, reduce the number of editable fields in the UI, and improve the robustness of command execution in the chat interface.