Skip to content

Fix Windows CHD support#59

Merged
xakep666 merged 3 commits into
xakep666:masterfrom
CatMe0w:fix-windows-libchdr
Jun 23, 2026
Merged

Fix Windows CHD support#59
xakep666 merged 3 commits into
xakep666:masterfrom
CatMe0w:fix-windows-libchdr

Conversation

@CatMe0w

@CatMe0w CatMe0w commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Windows CHD support was broken: WRN libchdr load failed, chd support is disabled err="The parameter is incorrect."

Caused by two separate bugs, fixed here:

  1. ar x on the MinGW import library (libchdr.dll.a) extracted a 56-byte COFF import stub and shipped that as libchdr.dll, so the real DLL was never packaged. The actual DLL lives in the build dir on Windows, so it's now taken from there.
  2. LoadLibraryEx was called with a relative name, which requires a absolute path. Fixed in load_library_windows.go.

A working Windows artifact is available in my fork for verification: https://github.com/CatMe0w/ps3netsrv-go/releases

@xakep666

xakep666 commented Jun 15, 2026

Copy link
Copy Markdown
Owner

@CatMe0w thank you for fixes.

If you have a large games collection compressed in chd I'm kindly asking to test #43. That MR should improve performance of directory listing if this directory contains a lot of chd's.

UPD: it's unnecessary now. I'll review this pr a bit later

Comment thread .github/workflows/libchdr.yml
Comment thread internal/osutil/load_library_windows.go Outdated
@xakep666

Copy link
Copy Markdown
Owner

Thank you! Merging

@xakep666
xakep666 merged commit e8aa6b2 into xakep666:master Jun 23, 2026
7 checks passed
@CatMe0w
CatMe0w deleted the fix-windows-libchdr branch June 23, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants