Skip to content

bugfix: support GLM-5.2 Jinja syntax via minja upgrade. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phantomlei3 wants to merge 1 commit into from
+37 −0
Closed

bugfix: support GLM-5.2 Jinja syntax via minja upgrade. #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions tests/xllm_service/chat_template/jinja_chat_template_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,43 @@ TEST(JinjaChatTemplate, OpenChatModel) {
EXPECT_EQ(result.value(), expected);
}

TEST(JinjaChatTemplate, RendersGlm52JinjaSyntax) {
const std::string template_str =
"{{ messages.0.role }}: {{ messages.0.content | capitalize }}";

nlohmann::ordered_json messages = {
{{"role", "user"}, {"content", "hello world"}}};

TokenizerArgs args;
args.chat_template(template_str);
args.bos_token("");
args.eos_token("");
JinjaChatTemplate template_(args);

auto result = template_.apply(messages);
ASSERT_TRUE(result.has_value());
EXPECT_EQ(result.value(), "user: Hello world");
}

TEST(JinjaChatTemplate, PreservesJinjaSyntaxInStringLiterals) {
const std::string template_str =
"{{ 'release.2 | capitalize' }}|"
"{{ messages.0.content | capitalize }}";

nlohmann::ordered_json messages = {
{{"role", "user"}, {"content", "hello world"}}};

TokenizerArgs args;
args.chat_template(template_str);
args.bos_token("");
args.eos_token("");
JinjaChatTemplate template_(args);

auto result = template_.apply(messages);
ASSERT_TRUE(result.has_value());
EXPECT_EQ(result.value(), "release.2 | capitalize|Hello world");
}

TEST(JinjaChatTemplate, ApplyChatTemplateKwargs) {
const std::string template_str =
"{% if enable_thinking %}<think>{% endif %}"
Expand Down