Stabilize download conformance tests under cache hits and fix chunk-cache nil race#120
Draft
Copilot wants to merge 3 commits into
Draft
Stabilize download conformance tests under cache hits and fix chunk-cache nil race#120Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Open
Agent-Logs-Url: https://github.com/wzshiming/xet/sessions/c6b8c772-1018-43e0-b266-6c9829255d62 Co-authored-by: wzshiming <6565744+wzshiming@users.noreply.github.com>
Agent-Logs-Url: https://github.com/wzshiming/xet/sessions/c6b8c772-1018-43e0-b266-6c9829255d62 Co-authored-by: wzshiming <6565744+wzshiming@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failed test
Stabilize download conformance tests under cache hits and fix chunk-cache nil race
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent conformance failures came from assuming both clients must always emit identical xorb download HTTP traffic. That assumption breaks when one side serves xorb data from local disk cache; additionally, a concurrent cleanup path could nil out disk cache state during prefetch persistence and panic.
Conformance: cache-aware download assertions
test/conformance/client/client_test.goto treat missing xorb HTTP requests as valid when caused by cache hits.Runtime safety: guard prefetch cache writeback race
download/chunk_cache.goto skipdc.put(...)whendiskCachehas been cleared by concurrentDone().