fix(ui): improve breadcrumb current page semantics#29
Open
wyf027 wants to merge 1 commit into
Open
Conversation
Contributor
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-current="page", defaulting to the last item unless an item setscurrentexplicitly.aria-hidden.onClickbuttons.separator: ReactNode, andBreadcrumbItem.current.Gap Notes
aria-current="page"on the current-page link: https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/aria-current="page"for current breadcrumb links and notes that a non-link current page item can also represent the current location: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-currentValidation
npm cinpx prettier --write packages/ui/src/components/navigation/Breadcrumb/Breadcrumb.tsx packages/ui/src/components/navigation/Breadcrumb/Breadcrumb.test.tsx docs/components/breadcrumb.mdnpm run lint:uinpm run typecheck:uinpm run test:ui(24 files, 75 tests)npm run build:uinpm run buildNotes
npm cistill reports existing Node 23 engine warnings and existing npm audit findings (1 low, 4 moderate, 2 high).npm run buildstill reports existing Browserslist and VitePress chunk-size warnings.