Skip to content

fix(ui): improve breadcrumb current page semantics#29

Open
wyf027 wants to merge 1 commit into
mainfrom
codex/breadcrumb-current-page-a11y-2026-07-05
Open

fix(ui): improve breadcrumb current page semantics#29
wyf027 wants to merge 1 commit into
mainfrom
codex/breadcrumb-current-page-a11y-2026-07-05

Conversation

@wyf027

@wyf027 wyf027 commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Mark the current breadcrumb item with aria-current="page", defaulting to the last item unless an item sets current explicitly.
  • Hide breadcrumb separators from assistive technology with aria-hidden.
  • Render static breadcrumb items as text instead of inert buttons, while preserving links and onClick buttons.
  • Add Breadcrumb tests for landmark/list structure, current page semantics, explicit current override, hidden separators, and clickable non-link items.
  • Update Breadcrumb docs for accessibility behavior, separator: ReactNode, and BreadcrumbItem.current.

Gap Notes

Validation

  • npm ci
  • npx prettier --write packages/ui/src/components/navigation/Breadcrumb/Breadcrumb.tsx packages/ui/src/components/navigation/Breadcrumb/Breadcrumb.test.tsx docs/components/breadcrumb.md
  • npm run lint:ui
  • npm run typecheck:ui
  • npm run test:ui (24 files, 75 tests)
  • npm run build:ui
  • npm run build

Notes

  • npm ci still reports existing Node 23 engine warnings and existing npm audit findings (1 low, 4 moderate, 2 high).
  • npm run build still reports existing Browserslist and VitePress chunk-size warnings.

@ecc-tools

ecc-tools Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant