Skip to content

fix(ui): improve collapse accordion accessibility#28

Open
wyf027 wants to merge 1 commit into
mainfrom
codex/collapse-accordion-a11y-2026-07-05
Open

fix(ui): improve collapse accordion accessibility#28
wyf027 wants to merge 1 commit into
mainfrom
codex/collapse-accordion-a11y-2026-07-05

Conversation

@wyf027

@wyf027 wyf027 commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add accordion semantics to Collapse triggers with aria-expanded and aria-controls.
  • Add generated trigger/panel ids and expose expanded content as named region panels.
  • Hide the visual expand/collapse glyph from the button accessible name.
  • Add Collapse tests for trigger-panel linkage, toggling, accordion mode, and disabled panels.
  • Update Collapse docs with accessibility behavior and precise string[] API types.

Gap Notes

Validation

  • npm ci
  • npx prettier --write packages/ui/src/components/navigation/Collapse/Collapse.tsx packages/ui/src/components/navigation/Collapse/Collapse.test.tsx docs/components/collapse.md
  • npm run lint:ui
  • npm run typecheck:ui
  • npm run test:ui (24 files, 74 tests)
  • npm run build:ui
  • npm run build

Notes

  • npm ci still reports existing Node 23 engine warnings and existing npm audit findings (1 low, 4 moderate, 2 high).
  • npm run build still reports existing Browserslist and VitePress chunk-size warnings.

@ecc-tools

ecc-tools Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant