Skip to content

fix(ui): improve upload keyboard accessibility#26

Open
wyf027 wants to merge 1 commit into
mainfrom
codex/upload-accessible-file-input-2026-07-04
Open

fix(ui): improve upload keyboard accessibility#26
wyf027 wants to merge 1 commit into
mainfrom
codex/upload-accessible-file-input-2026-07-04

Conversation

@wyf027

@wyf027 wyf027 commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Keep the Upload file input in the accessibility tree by using a visually hidden sr-only input instead of display: none.
  • Add a visible focus ring on the upload trigger through Tailwind peer-focus-visible classes.
  • Add list semantics for the controlled file list.
  • Add Upload tests for label association, keyboard focus, file metadata changes, disabled/native attributes, and file list semantics.
  • Document keyboard behavior plus missing disabled and triggerText props.

Gap Notes

Validation

  • npx prettier --write packages/ui/src/components/form/controls/Upload/Upload.tsx packages/ui/src/components/form/controls/Upload/Upload.test.tsx docs/components/upload.md
  • npm run lint:ui
  • npm run typecheck:ui
  • npm run test:ui (24 files, 74 tests)
  • npm run build:ui
  • npm run build

Notes

  • npm ci completed with existing Node 23 engine warnings and existing npm audit findings (1 low, 4 moderate, 2 high).
  • npm run build still reports existing Browserslist and VitePress chunk-size warnings.

@ecc-tools

ecc-tools Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant