v1.16.0 — approval integrity, single-use challenges & concurrency safety (5 High + Mediums)#21
Merged
Merged
Conversation
…concurrency safety (5 High + Mediums) High: - /approve requires the stored run to still REPRODUCE (RunReplay.Reproduce.Reproduced) before applying approvals; /challenges mints from the run's own signed policy decisions — approval can't drift from the reviewed graph. - Approval challenges are single-use: NonceLedger consumes each nonce on success (web /approve + McpProxy), so a challenge can't be replayed within its TTL. - DraftEmailAction referencing a private note is blocked at the gate (pol-draft-private-ref) before the adapter dereferences private content. - Archive is serialized and never deletes an existing archive dest (racing prunes drop the redundant live copy); WriteAtomic uses unique temp names. - Production startup guards are regression-tested (a Production-hosted test asserts startup refusal without a real auth boundary). Medium: - Owner/external-call sidecar signatures verify under the RECORDED key id (rotation-aware). - Dockerfile installs curl + healthchecks via curl (base image ships no wget/curl). - Live-Anthropic test asserts a non-empty bounded proposal (fails on a dead transport). - CI guards against a zero-match FS-E2E filter; stale README version snippet de-drifted. Known constraints documented (McpStdioClient single-connection, tenant-wide visibility, NuGet signing needs a cert). 260 passing + 3 env-gated skipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes a ninth external review (against v1.15.0). 260 passing + 3 env-gated skipped.
High
/approverequiresRunReplay.Reproduce(...).Reproduced(409 on behavior drift);/challengesmints from the run's own signed policy decisions, so approval can't diverge from the reviewed graph.NonceLedgerconsumes each nonce on success (web/approve+ MCP proxy), preventing replay within TTL.pol-draft-private-refrefuses a draft sourcing a private note before any dereference.Archiveis serialized and never deletes an existing archive dest; unique temp names.Medium
curl; live-Anthropic test fails on a dead transport; CI guards a zero-match FS-E2E filter; stale README version de-drifted.New tests: single-use challenge (unit + web replay), private-note block, production-startup refusal.
🤖 Generated with Claude Code