v1.12.0 — MCP audit/approval + policy hardening (8 High + 3 Medium)#16
Merged
Conversation
…h + 3 Medium)
High:
- MCP side effects require a durable signed audit: McpProxy.GateAndForward, when
wired with an IRunArtifactStore + key provider, persists a signed TraceBundle
BEFORE forwarding and fails closed if it can't be written.
- MCP approvals are challenge-bound: with an ApprovalChallengeService, an approval
is a server-issued challenge bound to {call fingerprint, tenant, expiry} — a raw
"n1" no longer approves, and a challenge for one call can't approve another.
- ConnectNpx requires a pinned, non-option package (name@1.2.3); call sites pin
@modelcontextprotocol/server-filesystem@2026.1.14.
- CI splits the live-LLM test (ANTHROPIC_API_KEY) from the npx FS-E2E step so the
secret and untrusted npm execution never share an environment.
- Production auth: trusted-proxy mode requires INTENTMESH_PROXY_SECRET; legacy
WEB_TOKEN no longer satisfies the prod auth guard (removed from quickstart).
- /readyz performs a real write + atomic-move + delete probe of the runs dir.
- Direct RunQueryAction is bounded by db.RowCap at execution.
- New pc-deletion-matches-approval postcondition: deleted files == approved refs.
Medium:
- Rate-limit key trusts X-Forwarded-For only behind the trusted proxy (matching
X-Proxy-Secret); otherwise the socket IP — a direct client can't rotate XFF.
- NormalizeForForward rewrites custom-mapper path args to the canonical in-root path.
- NuGet package signing remains a documented residual (needs a code-signing cert).
10 new tests; 245 passing + 3 env-gated skipped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes a sixth external review. Every finding verified against current
masterfirst. 245 passing + 3 env-gated skipped; 10 new tests.High — fixed
GateAndForward(wired with anIRunArtifactStore+ key provider) persists a signedTraceBundlebefore forwarding and fails closed if it can't (McpProxy_persists_a_signed_audit_before_forwarding).{call fingerprint, tenant, expiry}; rawn1no longer approves (McpProxy_approvals_must_be_challenge_bound_to_the_call).ConnectNpxrequiresname@1.2.3; rejects leading-dash + floating specs (ConnectNpx_requires_a_pinned_non_option_package). Call sites pin@modelcontextprotocol/server-filesystem@2026.1.14.INTENTMESH_PROXY_SECRET; legacyWEB_TOKENno longer satisfies the prod guard (removed from quickstart)./readyzprobes persistence — write + atomic-move + delete in the runs dir.RunQueryActionbounded bydb.RowCap(A_direct_run_query_is_bounded_by_the_row_cap).pc-deletion-matches-approval: deleted set == approved refs (Verification_proves_deleted_files_match_the_approved_refs).Medium — fixed
X-Forwarded-Foronly behind the trusted proxy (matchingX-Proxy-Secret); else socket IP.NormalizeForForwardrewrites custom-mapper path args to the canonical in-root path.🤖 Generated with Claude Code