Skip to content

Display todays + daily weather forecast - #16

Open
Apehaenger wants to merge 2 commits into
wuspy:masterfrom
Apehaenger:master
Open

Display todays + daily weather forecast#16
Apehaenger wants to merge 2 commits into
wuspy:masterfrom
Apehaenger:master

Conversation

@Apehaenger

Copy link
Copy Markdown
Contributor

Don't wanna bother 😇... but this is my preferred view:

IMG_20230301_183609

If interested in 😏

If so, and you don't like it with the *_OFFSET, I can surely change it to absolute values like ICON_TOP_CHAMBER, ICON_TOP_WEATHER_TODAY and ICON_TOP_WEATHER_DAILY to make it somehow better readable?

BTW: Did we lost the "colon" char during one of the last changes? 😬

@wuspy

wuspy commented Mar 1, 2023

Copy link
Copy Markdown
Owner

BTW: Did we lost the "colon" char during one of the last changes? 😬

Yep, I missed a few characters with the UTF8 changes. Should be fixed now on master.

As for this PR, I'll have to give it some thought. There's nothing wrong with it but it's getting pretty far removed from the Portal aesthetic at this point.

@Apehaenger

Copy link
Copy Markdown
Contributor Author

BTW: Did we lost the "colon" char during one of the last changes? grimacing

Yep, I missed a few characters with the UTF8 changes. Should be fixed now on master.

Quite thanks!!

As for this PR, I'll have to give it some thought. There's nothing wrong with it but it's getting pretty far removed from the Portal aesthetic at this point.

Well, I'm more the rational guys. I'm sad when I see unused pixel 😟. For "aesthetic" thoughts I'm really the improper person.
In my final "quick and dirty hacked" display variant, also the day number is centered and without the huge left border 🙈 (unused pixel, you know? 😃)

Don't feel urged in any way!! There's no need to discuss any shitty PR in.
It's your cool project, your code, your design, your decision.
It's simply my favored display content, and now that I've made a PR, it's written down from where I can merge it whenever I like 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants