You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Don't wanna bother 😇... but this is my preferred view:
If interested in 😏
If so, and you don't like it with the *_OFFSET, I can surely change it to absolute values like ICON_TOP_CHAMBER, ICON_TOP_WEATHER_TODAY and ICON_TOP_WEATHER_DAILY to make it somehow better readable?
BTW: Did we lost the "colon" char during one of the last changes? 😬
BTW: Did we lost the "colon" char during one of the last changes? 😬
Yep, I missed a few characters with the UTF8 changes. Should be fixed now on master.
As for this PR, I'll have to give it some thought. There's nothing wrong with it but it's getting pretty far removed from the Portal aesthetic at this point.
BTW: Did we lost the "colon" char during one of the last changes? grimacing
Yep, I missed a few characters with the UTF8 changes. Should be fixed now on master.
Quite thanks!!
As for this PR, I'll have to give it some thought. There's nothing wrong with it but it's getting pretty far removed from the Portal aesthetic at this point.
Well, I'm more the rational guys. I'm sad when I see unused pixel 😟. For "aesthetic" thoughts I'm really the improper person.
In my final "quick and dirty hacked" display variant, also the day number is centered and without the huge left border 🙈 (unused pixel, you know? 😃)
Don't feel urged in any way!! There's no need to discuss any shitty PR in.
It's your cool project, your code, your design, your decision.
It's simply my favored display content, and now that I've made a PR, it's written down from where I can merge it whenever I like 😏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't wanna bother 😇... but this is my preferred view:
If interested in 😏
If so, and you don't like it with the *_OFFSET, I can surely change it to absolute values like ICON_TOP_CHAMBER, ICON_TOP_WEATHER_TODAY and ICON_TOP_WEATHER_DAILY to make it somehow better readable?
BTW: Did we lost the "colon" char during one of the last changes? 😬