fix(http+mcp): tenant isolation for cross-project recall#220
Merged
Conversation
…p is Cursor-only) with Linux project-root headers Co-authored-by: Cursor <cursoragent@cursor.com>
REST handlers were passing X-Project-Id into memory_service while reusing the process-default cfg.store, breaking tenant isolation for cross-project recall. Resolve per-request stores via _get_store_for_project (same helper as MCP _StoreProxy) and only use the startup async store when it matches the tenant. Co-authored-by: Cursor <cursoragent@cursor.com>
…asks MCP session tasks inherit a stale REQUEST_PROJECT_ID from initialize, so cross-tenant tools/call must resolve tenant identity from the inbound HTTP request on request_ctx before the contextvar. Also refresh contextvars in the tool_filter wrapper when headers override the session default. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
_resolve_wrapped_default_store avoids MagicMock auto-creating _default_store, which broke _async_store_covers_tenant. Integration tests patch _get_store_for_project to return injected mock stores. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Project-Id(ADR-010)tools/callTest plan
Made with Cursor