fix(spec): add test_linker_cache to PyInstaller hiddenimports (TAP-4571)#196
Merged
Conversation
Module tapps_mcp.project.test_linker_cache (added by #195) was missing from tapps_mcp.spec hiddenimports, re-reddening master on test_all_modules_have_hidden_imports. Restores a green full suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tapps_mcp.project.test_linker_cache(added by #195, TAP-4575) was missing fromtapps_mcp.spechiddenimports, sotest_pyinstaller_spec.py::test_all_modules_have_hidden_importsfailed on master — 1 failed / 5960 passed. The frozen exe would ImportError at runtime on this module.Fix
Add the module to the spec hiddenimports (next to
test_linker).Test
pytest packages/tapps-mcp/tests/unit/test_pyinstaller_spec.py→ 3 passed. Restores greenpytest -m 'not slow'on the tapps-mcp package.Closes the Phase 0 residual on TAP-4571.
🤖 Generated with Claude Code