Fix inconsistent maxWait value in DB2 and PostgreSQL DB pool config samples#6195
Closed
BimsaraBodaragama wants to merge 16 commits into
Closed
Fix inconsistent maxWait value in DB2 and PostgreSQL DB pool config samples#6195BimsaraBodaragama wants to merge 16 commits into
BimsaraBodaragama wants to merge 16 commits into
Conversation
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
…amples The maxWait value in DB2 and PostgreSQL database pool configuration samples was set to 360000 ms (6 minutes) while all other database type documentation used 60000 ms (1 minute). This unifies the value to 60000 ms across all affected versions (IS 5.10.0 - 7.3.0). Fixes: wso2/product-is#27975
Contributor
📝 WalkthroughWalkthroughThe ChangesmaxWait correction and new IS 7.3.0 DB documentation
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md (1)
52-52:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix spelling: "delimeter" should be "delimiter".
The word is misspelled in the note about the DB2 command delimiter.
✏️ Proposed fix
- While running the DB2 scripts via the terminal, use the following DB2 command to run the DB2 scripts with the delimeter "/" since the default delimiter script for DB2 is ";". + While running the DB2 scripts via the terminal, use the following DB2 command to run the DB2 scripts with the delimiter "/" since the default delimiter script for DB2 is ";".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md` at line 52, Fix the spelling error in the note about running DB2 scripts via the terminal. Change the misspelled word "delimeter" to the correct spelling "delimiter" in the sentence that describes using the DB2 command with the "/" delimiter since the default delimiter script for DB2 is ";".Source: Coding guidelines
en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md (1)
52-52:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix spelling: "delimeter" should be "delimiter".
The word is misspelled in the note about the DB2 command delimiter.
✏️ Proposed fix
- While running the DB2 scripts via the terminal, use the following DB2 command to run the DB2 scripts with the delimeter "/" since the default delimiter script for DB2 is ";". + While running the DB2 scripts via the terminal, use the following DB2 command to run the DB2 scripts with the delimiter "/" since the default delimiter script for DB2 is ";".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md` at line 52, Fix the spelling error in the documentation note about running DB2 scripts. Change the misspelled word "delimeter" to "delimiter" in the sentence that describes using the DB2 command to run scripts with the delimiter, ensuring the correct spelling of the technical term is used throughout the documentation.Source: Coding guidelines
en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md (1)
52-52:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix spelling: "delimeter" should be "delimiter".
The word is misspelled in the note about the DB2 command delimiter.
✏️ Proposed fix
- While running the DB2 scripts via the terminal, use the following DB2 command to run the DB2 scripts with the delimeter "/" since the default delimiter script for DB2 is ";". + While running the DB2 scripts via the terminal, use the following DB2 command to run the DB2 scripts with the delimiter "/" since the default delimiter script for DB2 is ";".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md` at line 52, Locate the word "delimeter" in the note about running DB2 scripts via the terminal and correct the spelling to "delimiter" to match the correct English spelling used elsewhere in the same sentence.Source: Coding guidelines
🧹 Nitpick comments (8)
en/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use DB2 for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use DB2.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md` at line 5, The opening sentence in the file contains verbose phrasing that can be simplified. In the sentence that currently reads "you need to follow in order to use DB2 for this purpose", replace the phrase "in order to use" with "to use" to make the language more concise and clear per documentation guidelines.Source: Coding guidelines
en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use PostgreSQL for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use PostgreSQL.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md` at line 5, Simplify the opening sentence by replacing the phrase "in order to use" with "to use" where it appears in the context of PostgreSQL configuration. This change makes the language more concise and aligns with documentation guidelines while maintaining the same meaning. Update the sentence to read "you need to follow to use PostgreSQL for this purpose" instead of "you need to follow in order to use PostgreSQL for this purpose."Source: Coding guidelines
en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use PostgreSQL for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use PostgreSQL.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md` at line 5, In the opening sentence of the document, replace the phrase "in order to use" with "to use" to make the language more concise and clear. The sentence currently reads "you need to follow in order to use PostgreSQL for this purpose" and should be simplified to "you need to follow to use PostgreSQL for this purpose".Source: Coding guidelines
en/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use PostgreSQL for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use PostgreSQL.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md` at line 5, The opening sentence contains the verbose phrase "in order to use" which can be simplified for better clarity and conciseness in accordance with documentation guidelines. Locate the phrase "in order to use" in the first paragraph describing the steps needed for PostgreSQL configuration, and replace it with the shorter phrase "to use". This maintains the same meaning while improving readability.Source: Coding guidelines
en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use DB2 for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use DB2.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md` at line 5, Simplify the phrase "in order to use" to "to use" in the sentence on line 5 of the change-to-ibm-db2.md file. This makes the documentation more concise and follows standard documentation guidelines for clear, direct language. Simply remove the words "in order" and keep "to use" in the same sentence context.Source: Coding guidelines
en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use DB2 for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use DB2.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md` at line 5, In the documentation file, find the sentence containing the phrase "in order to use DB2 for this purpose" and simplify it by replacing "in order to use" with "to use". This removes unnecessary wordiness while maintaining clarity, making the sentence read as "you need to follow to use DB2 for this purpose" in compliance with documentation style guidelines that prefer concise language.Source: Coding guidelines
en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use DB2 for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use DB2.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md` at line 5, Simplify the opening sentence by replacing the phrase "in order to use" with "to use" to make the language more concise and align with documentation guidelines. Locate the sentence containing "you need to follow in order to use DB2 for this purpose" and modify it to read "you need to follow to use DB2 for this purpose" for clearer, more direct phrasing.Source: Coding guidelines
en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md (1)
5-5: ⚡ Quick winSimplify opening sentence per documentation guidelines.
The phrase "in order to use" can be shortened to "to use" for clearer, more concise language.
✏️ Proposed simplification
-By default, WSO2 Identity Server uses the embedded H2 database as the database -for storing user management and registry data. Given below are the steps -you need to follow in order to use PostgreSQL for this purpose. +By default, WSO2 Identity Server uses the embedded H2 database as the database +for storing user management and registry data. Follow these steps to use PostgreSQL.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md` at line 5, The opening sentence on line 5 contains the phrase "in order to use" which can be simplified to "to use" to make the documentation more concise and follow writing guidelines. Locate the text "you need to follow in order to use PostgreSQL for this purpose" and remove "in order" so the phrase reads "you need to follow to use PostgreSQL for this purpose" for improved clarity and brevity.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@en/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 52: In the note about running DB2 scripts via the terminal, correct the
spelling of "delimeter" to "delimiter" in the sentence that describes using the
DB2 command to run scripts with the "/" delimiter instead of the default ";"
delimiter.
---
Outside diff comments:
In
`@en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 52: Fix the spelling error in the documentation note about running DB2
scripts. Change the misspelled word "delimeter" to "delimiter" in the sentence
that describes using the DB2 command to run scripts with the delimiter, ensuring
the correct spelling of the technical term is used throughout the documentation.
In
`@en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 52: Locate the word "delimeter" in the note about running DB2 scripts via
the terminal and correct the spelling to "delimiter" to match the correct
English spelling used elsewhere in the same sentence.
In
`@en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 52: Fix the spelling error in the note about running DB2 scripts via the
terminal. Change the misspelled word "delimeter" to the correct spelling
"delimiter" in the sentence that describes using the DB2 command with the "/"
delimiter since the default delimiter script for DB2 is ";".
---
Nitpick comments:
In
`@en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 5: Simplify the opening sentence by replacing the phrase "in order to
use" with "to use" to make the language more concise and align with
documentation guidelines. Locate the sentence containing "you need to follow in
order to use DB2 for this purpose" and modify it to read "you need to follow to
use DB2 for this purpose" for clearer, more direct phrasing.
In
`@en/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md`:
- Line 5: In the opening sentence of the document, replace the phrase "in order
to use" with "to use" to make the language more concise and clear. The sentence
currently reads "you need to follow in order to use PostgreSQL for this purpose"
and should be simplified to "you need to follow to use PostgreSQL for this
purpose".
In
`@en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 5: Simplify the phrase "in order to use" to "to use" in the sentence on
line 5 of the change-to-ibm-db2.md file. This makes the documentation more
concise and follows standard documentation guidelines for clear, direct
language. Simply remove the words "in order" and keep "to use" in the same
sentence context.
In
`@en/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md`:
- Line 5: The opening sentence on line 5 contains the phrase "in order to use"
which can be simplified to "to use" to make the documentation more concise and
follow writing guidelines. Locate the text "you need to follow in order to use
PostgreSQL for this purpose" and remove "in order" so the phrase reads "you need
to follow to use PostgreSQL for this purpose" for improved clarity and brevity.
In
`@en/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 5: The opening sentence in the file contains verbose phrasing that can be
simplified. In the sentence that currently reads "you need to follow in order to
use DB2 for this purpose", replace the phrase "in order to use" with "to use" to
make the language more concise and clear per documentation guidelines.
In
`@en/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md`:
- Line 5: The opening sentence contains the verbose phrase "in order to use"
which can be simplified for better clarity and conciseness in accordance with
documentation guidelines. Locate the phrase "in order to use" in the first
paragraph describing the steps needed for PostgreSQL configuration, and replace
it with the shorter phrase "to use". This maintains the same meaning while
improving readability.
In
`@en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.md`:
- Line 5: In the documentation file, find the sentence containing the phrase "in
order to use DB2 for this purpose" and simplify it by replacing "in order to
use" with "to use". This removes unnecessary wordiness while maintaining
clarity, making the sentence read as "you need to follow to use DB2 for this
purpose" in compliance with documentation style guidelines that prefer concise
language.
In
`@en/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md`:
- Line 5: Simplify the opening sentence by replacing the phrase "in order to
use" with "to use" where it appears in the context of PostgreSQL configuration.
This change makes the language more concise and aligns with documentation
guidelines while maintaining the same meaning. Update the sentence to read "you
need to follow to use PostgreSQL for this purpose" instead of "you need to
follow in order to use PostgreSQL for this purpose."
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: f156719a-6d3f-4bee-b453-9f07d7df889f
📒 Files selected for processing (16)
en/identity-server/5.10.0/docs/setup/changing-to-ibm-db2.mden/identity-server/5.11.0/docs/setup/changing-to-ibm-db2.mden/identity-server/6.0.0/docs/deploy/change-to-ibm-db2.mden/identity-server/6.0.0/docs/deploy/change-to-postgresql.mden/identity-server/6.1.0/docs/deploy/change-to-ibm-db2.mden/identity-server/6.1.0/docs/deploy/change-to-postgresql.mden/identity-server/7.0.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.mden/identity-server/7.0.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.mden/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.mden/identity-server/7.1.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.mden/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.mden/identity-server/7.2.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.mden/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.mden/identity-server/7.3.0/docs/deploy/configure/databases/carbon-database/change-to-postgresql.mden/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-ibm-db2.mden/identity-server/next/docs/deploy/configure/databases/carbon-database/change-to-postgresql.md
Member
Author
|
@coderabbitai This PR has been superseded by #6197, which contains the same fix but with a cleaner commit history (3 logical commits instead of one per file). Please close your review on this PR. |
Member
Author
Contributor
|
✅ Action performedComments resolved. Approval is disabled; enable |
Contributor
|
✅ Action performedComments resolved. Approval is disabled; enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
maxWaitvalue in the sample DB pool configurations for DB2 and PostgreSQL documentation was set to360000ms (6 minutes), while all other database type documentation used60000ms (1 minute). This PR unifies the value to60000ms across all affected versions.Affected versions: IS 5.10.0 – 7.3.0 (+ next)
Files changed (16):
change-to-ibm-db2.md— 5.10.0, 5.11.0, 6.0.0, 6.1.0, 7.0.0, 7.1.0, 7.2.0, 7.3.0, nextchange-to-postgresql.md— 6.0.0, 6.1.0, 7.0.0, 7.1.0, 7.2.0, 7.3.0, nextFixes: wso2/product-is#27975