Skip to content

Fix Build & push event-gateway-controller to temp registry#2224

Merged
tharindu1st merged 1 commit into
wso2:mainfrom
senthuran16:fix-event-gateway-controller-workflow-fail
Jun 22, 2026
Merged

Fix Build & push event-gateway-controller to temp registry#2224
tharindu1st merged 1 commit into
wso2:mainfrom
senthuran16:fix-event-gateway-controller-workflow-fail

Conversation

@senthuran16

@senthuran16 senthuran16 commented Jun 19, 2026

Copy link
Copy Markdown
Member

Purpose

$Subject - https://github.com/wso2/api-platform/actions/runs/26418498003/job/77767999887

Fix

Replace the raw docker buildx build command with make -C gateway/gateway-controller build-and-push-multiarch, matching the pattern used by every other step in this workflow. The Makefile already passes all required build contexts (policies, target, sdk, sdk-core, common, build-manifest) correctly.

The policies directory (gateway/target/build/gateway-controller/policies) is populated by the gateway-runtime step that runs earlier in the workflow via its extract-policies target.

Commit 0f8b59a (refactor(gateway): source policy defs from gateway-builder output) changed the Dockerfile to replace the checked-in default-policies/ folder with a COPY --from=policies . /app/default-policies build context. This was added to the Makefile's build-and-push-multiarch correctly, but the jfrog-scan.yaml step was not updated.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 14d00a7b-7dae-4b3d-a6c7-4f757e028e61

📥 Commits

Reviewing files that changed from the base of the PR and between 623d8b4 and 3d4de25.

📒 Files selected for processing (1)
  • .github/workflows/jfrog-scan.yaml

📝 Walkthrough

Workflow Build Step Alignment

Updated the "Build & push event-gateway-controller to temp registry" step in the jfrog-scan workflow to use the project's shared Make target instead of an inline docker buildx command.

What changed:

  • Replaced cd gateway/gateway-controller && docker buildx build ... with make -C gateway/gateway-controller build-and-push-multiarch
  • Set IMAGE_NAME and VERSION parameters to ensure correct registry and versioning for the temporary build

Why:
A previous Dockerfile refactoring changed how policy definitions are sourced during the build process. The inline docker command was not passing the required build contexts to support this change. The shared Make target handles all necessary build contexts correctly, including policies that are populated earlier in the workflow.

Impact:
Resolves the build failure and aligns this workflow step with the pattern used by other steps in the workflow, improving consistency and maintainability.

Walkthrough

The JFrog scan workflow's step for building and pushing the event-gateway-controller image is updated. The previous inline docker buildx build command, which explicitly specified build contexts, platforms, build arguments, target, tag, and push flag, is replaced with a make -C gateway/gateway-controller build-and-push-multiarch invocation. The new step passes IMAGE_NAME=localhost:5000/event-gateway-controller and VERSION=trivy as make variables.

Suggested Reviewers

  • Tharsanan1
  • tharindu1st
  • pubudu538
  • Krishanx92
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides clear Purpose, explanation of the fix, and context about the root cause (commit 0f8b59a). However, it is missing sections required by the repository template: Goals, Approach, User stories, Documentation, Automation tests, Security checks, Samples, Related PRs, and Test environment. Complete the missing template sections, particularly Goals (what the fix achieves), Automation tests (verification of the change), and Test environment (where this was validated).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the Build & push step for event-gateway-controller by replacing a raw docker buildx command with a make target, directly corresponding to the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tharindu1st tharindu1st merged commit 5409c9d into wso2:main Jun 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants