ci: move off broken pnpm 11.12.0 and take the pending action majors - #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the four stuck dependabot majors. They share one file set, so verifying them together costs one CI run instead of four.
pnpm 11.12.0 is deprecated upstream: "This release is broken. Please upgrade to v11.13.1 or newer." Its
@pnpm/exebuild shipped without a binary. That is why #19 failed — action-setup v6 installs@pnpm/exe, v4 installs plainpnpm, so v4 never touched the broken artifact:pnpm 11.20.0 itself refuses to run against a
packageManagerpin of 11.12.0. So the bump is required regardless of which action version we land on.version:is dropped from all three workflows —packageManagerin package.json is now the only place the pnpm version is written, so the two cannot drift again.The one real breaking change is in #23, and it is silent: upload-pages-artifact v4.0.0 stopped including dotfiles, which would drop the
.nojekyllthat demo.yml writes two lines earlier. Restored withinclude-hidden-files: true.name/path/retention-daysall still present; newarchiveinput defaults to the old behavior# v3comment dependabot left on a v4 SHAVerified locally on pnpm 11.20.0:
--frozen-lockfileinstall clean, typecheck and lint green.release.yml only runs on a
v*tag, so #20 and #28 are not exercised here — those two are verified by reading the actions'action.ymlinput surfaces, not by a run. demo.yml is in its own paths filter and will deploy on merge, which does exercise #23.reviewwill fail as usual: dependency graph is disabled on this repo.