Treat agent output_path as a log stem#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_agent(output_path=...)as a semantic log stem instead of an exact stdout file path<stem>.stdout.jsonland<stem>.stderr.log<stem>/review.mdVerification
uv run pytest src/tests/test_agent_tools.py::test_spawn_agent_schema_exposes_resume_fields src/tests/test_agent_tools.py::test_spawn_agent_treats_output_path_as_log_stemuv run pytest src/tests/test_agent_tools.py src/tests/test_worker_sessions.py src/tests/test_harness.pyuv run ruff format --check . && uv run ruff check .uv run --extra dev pyrightNotes
_tail_text()fallback; if a log path is still wrong, manifest generation should fail loudly.uv run pytestcurrently has two unrelated console rendering failures insrc/tests/test_console.pyaround Rich bold ANSI output; the changed areas pass.