Skip to content

Treat agent output_path as a log stem#72

Merged
fazpu merged 1 commit into
mainfrom
fix/output-path-log-stems
May 14, 2026
Merged

Treat agent output_path as a log stem#72
fazpu merged 1 commit into
mainfrom
fix/output-path-log-stems

Conversation

@fazpu

@fazpu fazpu commented May 14, 2026

Copy link
Copy Markdown
Member

Summary

  • treat spawn_agent(output_path=...) as a semantic log stem instead of an exact stdout file path
  • write worker stdout/stderr beside the stem as <stem>.stdout.jsonl and <stem>.stderr.log
  • pass explicit stdout/stderr paths into the subprocess spawner
  • add regression coverage for the artifact-directory collision that can occur when a worker writes <stem>/review.md

Verification

  • uv run pytest src/tests/test_agent_tools.py::test_spawn_agent_schema_exposes_resume_fields src/tests/test_agent_tools.py::test_spawn_agent_treats_output_path_as_log_stem
  • uv run pytest src/tests/test_agent_tools.py src/tests/test_worker_sessions.py src/tests/test_harness.py
  • uv run ruff format --check . && uv run ruff check .
  • uv run --extra dev pyright

Notes

  • Intentionally does not add a defensive _tail_text() fallback; if a log path is still wrong, manifest generation should fail loudly.
  • Full uv run pytest currently has two unrelated console rendering failures in src/tests/test_console.py around Rich bold ANSI output; the changed areas pass.

@fazpu fazpu merged commit 7e51727 into main May 14, 2026
3 checks passed
@fazpu fazpu deleted the fix/output-path-log-stems branch May 14, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant