feat: add WIP-103 proof verification to CLI#403
Open
paolodamico wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds WIP-103 proof verification to the CLI.
Note
Medium Risk
Introduces local ZK ownership verification and ProveKit profile tweaks; correctness matters for proof acceptance but scope is CLI and dev-build config, not on-chain verifier contracts.
Overview
Adds
walletkit proof verify-ownershipfor WIP-103 ownership proofs: reads base64url proof data (file or stdin), decodes CBOR intoOwnershipProof, and checks it locally withverify_ownership_proofusing--nonceand--subfield elements. Human and JSON output include verification status and merkle root; failures exit non-zero.The CLI pulls in
world-id-proof(zk-ownership-verify),ciborium, andprovekit-verifier(via lock/workspace). Dev builds disable debug-assertions on ProveKit crates so serialized Whir proofs match production (debug-onlypatternis not serialized).On-chain verify output now uses shared
pass_label/fail_labelhelpers with green/red[PASS]/[FAIL]when stdout is a TTY.Reviewed by Cursor Bugbot for commit 5536b2d. Bugbot is set up for automated code reviews on this repo. Configure here.