fix(color): correct primitive grey/950 to #1F1F1F (UI Kit 5)#26
Merged
Conversation
Primitive `grey.950` was `#181818`, but UI Kit 5.0 (the source of truth) defines it as `#1F1F1F`. Since `semantic.color.text.primary`, `action.primary`, and friends resolve to `grey.950`, this made the most common text/foreground color render a shade too dark on every platform. Updates the definition and regenerates the committed Android/iOS color outputs. Web outputs are produced at publish time. Note: hand-written component literals (e.g. NucleusCardTheme.kt) still hardcode 0x181818 and are intentionally left out of this token-only fix; they can be reconciled separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Priva28
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Primitive
grey.950was#181818, but UI Kit 5.0 (the source of truth) defines it as#1F1F1F.semantic.color.text.primary,action.primary,icon.primary, etc. all resolve togrey.950, so the most common text/foreground color rendered a shade too dark on every platform.Changes
tokens/definitions/color/primitive.json:grey.950#181818→#1F1F1FNucleusPrimitiveColors.kt,NucleusColor+Primitives.swift,NucleusColor+Semantics.swift). Web outputs are produced at publish time.Notes
#1F1F1F; grey/700 =#7D7D7Detc. already matched).NucleusCardTheme.kt) still hardcode0x181818and are intentionally left out of this token-only fix — they can be reconciled separately.npm run build,typecheck,lint, andformat:checkall pass.Found while adopting Nucleus tokens in app-backend SDUI V4.
🤖 Generated with Claude Code