Conversation
…t skips evaluation in CI
randrescastaneda
left a comment
randrescastaneda
left a comment
There was a problem hiding this comment.
Hi @Tefera19 ,
Thank you for the PR. Unfortunatley, there are something that I still don't understad. Could you please address those comments? Also, could you please make sure that the stamp suite is fully tested in the unit tests? You can create mock functions or data if needed.
|
Hi @randrescastaneda , I just wanted to let you know that I've deleted README.html file. I also created unit test for dlw_get_gmd(). The test unit shows how to setup {stamp} to save dlw data. |
bbrunckh
left a comment
bbrunckh
left a comment
There was a problem hiding this comment.
Hi, coming on to help maintain and took a quick look at this one.
It is not obvious to me exactly what problem {stamp} is fixing here other than replacing {pins}. Lighter weight? I know there are advantages for tracking files in a more complex data pipeline, but not sure how applies here for datalibweb only or where {pins} was deficient.
@Tefera19 are you able to add a brief comment to explain?
3 participants
This PR contains additional vigneets and {stamp} implementation.