fix: use path-based versioning (/v2/open) not query param (?v=2)#28
Merged
Conversation
Remove the `v` query param approach and `UnknownVersionView`. Future versions get their own path prefix (e.g. /v2/open), keeping /open as the permanent v1 route. Update docs accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?v=2query param to path-based (/v2/open)UnknownVersionViewcomponent and thevparam check from/open/openremains unchanged as the permanent v1 routedocs/api-versioning.md: convention table, rules, and "adding a new version" steps now reflect path-based approachTest plan
/open?owner=x&repo=y&issue=1still workspnpm buildpassespnpm lintpasses🤖 Generated with Claude Code