fix!: remove legacy nix run code path causing stderr noise - #371
Merged
Conversation
BREAKING CHANGE: Nix >= 2.4 is now required. The pre-2.4 `nix run nixpkgs.X` fallback and version-checking shell functions (verlte/verlt) are removed. Only the modern `nix shell nixpkgs#X` path remains. Replace the untestable test-legacy-nix CI job with test-no-stderr-noise that asserts the wrapper has no legacy pattern. Fixes #365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nix run nixpkgs.Xfallback and version-checking shell functions (verlte/verlt) from the wrapper scriptnix shell nixpkgs#Xpath remains, which works with nix 2.4+test-legacy-nixCI job (which installed modern nix and never actually tested the legacy path) withtest-no-stderr-noisethat asserts the wrapper doesn't contain the legacynix run nixpkgs.patternBREAKING CHANGE: Nix >= 2.4 is now required (released Dec 2021).
Fixes #365