tls13: set sess_free_cb to null after calling.#10989
Open
philljj wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the TLS 1.3 PSK/session-ticket handling in DoPreSharedKeys() by clearing the session free callback pointer after it has been invoked, alongside the existing session pointer and callback-context cleanup. This reduces the chance of accidental double-invocation if the current PSK entry is revisited or reused after cleanup.
Changes:
- After invoking
current->sess_free_cb(...), setcurrent->sess_free_cb = NULLin all relevant cleanup paths. - Keep cleanup consistent with the existing pattern of nulling
current->sessand zeroingcurrent->sess_free_cb_ctx.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set
->sess_free_cb = NULL;after calling session free callback and nulling the session.Fixes zd#22190.