20260720-linuxkm-CMAC-native by douzzer · Pull Request #10980 · wolfSSL/wolfssl

douzzer · 2026-07-23T04:00:02Z

Implement glue logic for Linux kernel registration of native cmac(aes) implementation, and fix gaps in several other struct shash_alg glue implementations:

linuxkm/lkcapi_aes_glue.c, linuxkm/lkcapi_glue.c, configure.ac: implement linuxkm cmac(aes) glue.

linuxkm/lkcapi_sha_glue.c: fix sha.W lifecycle management to prevent leaks:

separate WC_LINUXKM_SHA_IMPLEMENT() into WC_LINUXKM_SHA1_IMPLEMENT() (no fixes
needed) and WC_LINUXKM_SHA2_IMPLEMENT() (with associated new helpers
WC_LINUXKM_SHA2_FREE_W(), WC_LINUXKM_SHA2_DECL_W(), WC_LINUXKM_SHA2_PUSH_W(),
and WC_LINUXKM_SHA2_POP_W(), that move .W to a stack buffer).
Reimplement SHA-2 one-shot digest callback to use only direct wolfCrypt calls
rather than proxy to other callbacks.

linuxkm/linuxkm_wc_port.h, linuxkm/module_hooks.c: implement magic checks on kernel struct wolfSSL_Mutex in WOLFSSL_LINUXKM_VERBOSE_DEBUG builds.

linuxkm/lkcapi_sha_glue.c: refactor SHA-3 state around struct km_Sha3TfmCtx,
adding km_sha3_init_tfm(), km_sha3_exit_tfm(), km_sha3_alloc_tstate(), and
km_sha3_free_tstate(), implementing garbage collection of abandoned shash_desc
objects at .exit_tfm.

linuxkm/lkcapi_sha_glue.c: add struct km_sha3_export_state, and implement km_sha3_export() and per-alg _import() methods, and km_sha3_test_export_import().

linuxkm/lkcapi_sha_glue.c: fix export/import for HMAC:

add to struct km_sha_hmac_pstate members desc_list_lock, desc_list, export_list, and export_list_len;
add struct km_sha_hmac_export_state;
add km_hmac_alloc_tstate(), km_hmac_export(), km_hmac_import(), km_hmac_test_export_import();
and update km_hmac_*() and WC_LINUXKM_HMAC_IMPLEMENT() to implement.

test/:

fixes for NO_DH;
fixes in test_wc_ed448_import_public() and test_wc_Ed448DecisionCoverage() for FIPS v6;
fixes in tests/api/test_sha3.c for KMAC keysize in FIPS builds.

tested with

wolfssl-multi-test.sh ...
check-source-text-fips-dev
quantum-safe-wolfssl-all-crypto-only-noasm-fips-dev-linuxkm-next-clang-tidy
'.*insmod.*'
all-crypto-openssl-extra-coexist-fips-dev

github-actions · 2026-07-23T04:10:52Z

MemBrowse Memory Report

linuxkm-pie

Data: __patchable_function_entries +200 B (+0.8%, 26,160 B)

linuxkm-standard

Data: __patchable_function_entries +176 B (+0.4%, 48,792 B)
No memory changes detected for:
gcc-arm-cortex-m0plus
gcc-arm-cortex-m3
gcc-arm-cortex-m4
gcc-arm-cortex-m4-baremetal
gcc-arm-cortex-m4-crypto-only
gcc-arm-cortex-m4-dtls13
gcc-arm-cortex-m4-min-ecc
gcc-arm-cortex-m4-openssl-compat
gcc-arm-cortex-m4-pkcs7
gcc-arm-cortex-m4-pq
gcc-arm-cortex-m4-rsa-only
gcc-arm-cortex-m4-sp-math
gcc-arm-cortex-m4-tls12
gcc-arm-cortex-m4-tls13
gcc-arm-cortex-m7
gcc-arm-cortex-m7-pq
gcc-arm-cortex-m7-tls13
stm32-sim-stm32h753

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #10980

Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

philljj · 2026-07-23T17:23:43Z

Retest this please.

FATAL: [ssh-agent] Unable to start agent
java.io.IOException: Unexpected EOF

…ment linuxkm cmac(aes) glue.

…leaks: * separate WC_LINUXKM_SHA_IMPLEMENT() into WC_LINUXKM_SHA1_IMPLEMENT() (no fixes needed) and WC_LINUXKM_SHA2_IMPLEMENT() (with associated new helpers WC_LINUXKM_SHA2_FREE_W(), WC_LINUXKM_SHA2_DECL_W(), WC_LINUXKM_SHA2_PUSH_W(), and WC_LINUXKM_SHA2_POP_W(), that move .W to a stack buffer). * Reimplement SHA-2 one-shot digest callback to use only direct wolfCrypt calls rather than proxy to other callbacks.

…ecks on kernel struct wolfSSL_Mutex in WOLFSSL_LINUXKM_VERBOSE_DEBUG builds.

…TfmCtx, adding km_sha3_init_tfm(), km_sha3_exit_tfm(), km_sha3_alloc_tstate(), and km_sha3_free_tstate(), implementing garbage collection of abandoned shash_desc objects at .exit_tfm.

…ment km_sha3_export() and per-alg _import() methods, and km_sha3_test_export_import().

* add to struct km_sha_hmac_pstate members desc_list_lock, desc_list, export_list, and export_list_len; * add struct km_sha_hmac_export_state; * add km_hmac_alloc_tstate(), km_hmac_export(), km_hmac_import(), km_hmac_test_export_import(); * and update km_hmac_*() and WC_LINUXKM_HMAC_IMPLEMENT(() to implement.

* fixes for NO_DH; * fixes in test_wc_ed448_import_public() and test_wc_Ed448DecisionCoverage() for FIPS v6; * fixes in tests/api/test_sha3.c for KMAC keysize in FIPS builds.

… conjunctions to fix constant-folding-provoked compiler warnings around fips_enabled; for clarity, rename internal macros WC_LINUXKM_HAVE_SELFTEST and WC_LINUXKM_HAVE_SELFTEST_FULL to WC_LINUX_CONFIG_SELFTESTS and WC_LINUX_CONFIG_SELFTESTS_FULL respectively.

…hten up SHA-3 allocations, avoiding frivolous struct km_sha_state (with inline wc_Sha512) for SHA-3.

* Eliminate pointer from export blob, replacing it with a TFM-specific random cookie and per-desc serial ID. * Fixes kernel address disclosure risk, handle forgery risk, cross-TFM confusion risk, and heap pointer reuse risk.

…sl/wolfcrypt/settings.h: * Revert earlier changes adding WC_SHA256_W_SIZE and WC_SHA512_W_SIZE. * Add WC_SHA2_NO_SMALL_STACK to allow the W work buffer to move back onto the stack. * In wolfssl/wolfcrypt/settings.h, define WC_SHA2_NO_SMALL_STACK by default when WOLFSSL_KERNEL_MODE, and add a clause to #undef WOLFSSL_SMALL_STACK when building the SHA-2 implementations. linuxkm/lkcapi_sha_glue.c: * Refactor out superfluous struct km_sha_state. * Clean up some macro dynamics. * Add static asserts on HASH_MAX_STATESIZE to WC_LINUXKM_SHA1_IMPLEMENT() and WC_LINUXKM_SHA2_IMPLEMENT().

…ntegrity check and DRBG.

… SEGV from gcc misoptimization.

…_AesGcmInit().

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #10980

Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

douzzer requested review from philljj, wolfSSL-Bot and wolfSSL-Fenrir-bot July 23, 2026 04:00

douzzer assigned wolfSSL-Bot Jul 23, 2026

wolfSSL-Fenrir-bot reviewed Jul 23, 2026

View reviewed changes

Comment thread linuxkm/lkcapi_sha_glue.c

Comment thread linuxkm/lkcapi_sha_glue.c Outdated

Comment thread wolfcrypt/src/sha256.c

Comment thread wolfcrypt/src/sha256.c

Comment thread linuxkm/lkcapi_sha_glue.c

philljj assigned douzzer and unassigned wolfSSL-Bot Jul 23, 2026

douzzer commented Jul 23, 2026

View reviewed changes

Comment thread linuxkm/lkcapi_sha_glue.c

douzzer added 16 commits July 23, 2026 19:03

linuxkm/lkcapi_aes_glue.c, linuxkm/lkcapi_glue.c, configure.ac: imple…

1c7e4bf

…ment linuxkm cmac(aes) glue.

linuxkm/linuxkm_wc_port.h, linuxkm/module_hooks.c: implement magic ch…

6d33fdd

…ecks on kernel struct wolfSSL_Mutex in WOLFSSL_LINUXKM_VERBOSE_DEBUG builds.

linuxkm/lkcapi_sha_glue.c: refactor SHA-3 state around struct km_Sha3…

808409e

…TfmCtx, adding km_sha3_init_tfm(), km_sha3_exit_tfm(), km_sha3_alloc_tstate(), and km_sha3_free_tstate(), implementing garbage collection of abandoned shash_desc objects at .exit_tfm.

linuxkm/lkcapi_sha_glue.c: add struct km_sha3_export_state, and imple…

7002bc3

…ment km_sha3_export() and per-alg _import() methods, and km_sha3_test_export_import().

test/:

3a6a7e4

* fixes for NO_DH; * fixes in test_wc_ed448_import_public() and test_wc_Ed448DecisionCoverage() for FIPS v6; * fixes in tests/api/test_sha3.c for KMAC keysize in FIPS builds.

linuxkm/lkcapi_sha_glue.c: add struct km_sha3_state_by_pointer to tig…

134e4a2

…hten up SHA-3 allocations, avoiding frivolous struct km_sha_state (with inline wc_Sha512) for SHA-3.

wolfssl/wolfcrypt/types.h: add wc_static_assert_if_const().

289d477

configure.ac: enable SHA512 for fips=lean-aesgcm, to support SHA512 i…

0a41189

…ntegrity check and DRBG.

tests/api/test_kdf.c: fix NO_SHA in test_wc_KdfFeatureCoverage().

ac601ea

wolfcrypt/src/cpuid.c: in cpuid_flag(), refactor out XMEMSET() to fix…

fd9c3d1

… SEGV from gcc misoptimization.

wolfcrypt/src/aes.c: implement WC_C_DYNAMIC_FALLBACK for AES-NI in wc…

d4c3410

…_AesGcmInit().

douzzer force-pushed the 20260720-linuxkm-CMAC-native branch from 3e6a2f1 to d4c3410 Compare July 24, 2026 00:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

20260720-linuxkm-CMAC-native#10980

20260720-linuxkm-CMAC-native#10980
douzzer wants to merge 16 commits into
wolfSSL:masterfrom
douzzer:20260720-linuxkm-CMAC-native

douzzer commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

wolfSSL-Fenrir-bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philljj commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

douzzer commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report

linuxkm-pie

linuxkm-standard

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #10980

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philljj commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #10980

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 23, 2026 •

edited

Loading