Add WISeKey/SealSQ VaultIC secure element port#10974
Open
dgarske wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds an in-tree wolfSSL port that offloads P-256 ECC operations and certificate loading to the WISeKey/SealSQ VaultIC secure element via PK callbacks, with build-system wiring for autotools/CMake.
Changes:
- Added VaultIC PK callback implementations (sign/verify/keygen/ECDH) and certificate-loading helper.
- Exposed a public header and port README with build/usage/provisioning notes.
- Added
--enable-vaulticautotools option and a corresponding CMake option; wired sources/headers into build.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfssl/wolfcrypt/port/sealsq/vaultic.h | Declares the VaultIC PK callback + certificate-loading API exported by the port. |
| wolfssl/wolfcrypt/include.am | Installs the new public VaultIC header when BUILD_VAULTIC is enabled. |
| wolfcrypt/src/port/sealsq/vaultic.c | Implements ECC callbacks and certificate loading using the external VaultIC-TLS SDK. |
| wolfcrypt/src/port/sealsq/README.md | Documents dependencies, build flags, usage, and devkit/provisioning notes. |
| wolfcrypt/src/include.am | Adds the VaultIC port source to libwolfssl when BUILD_VAULTIC is enabled and distributes the README. |
| configure.ac | Adds --enable-vaultic, defines WOLFSSL_VAULTIC, and enables PK callbacks for autotools builds. |
| CMakeLists.txt | Adds a WOLFSSL_VAULTIC option and excludes the sealsq port directory from header processing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an in-tree wolfSSL port for the WISeKey/SealSQ VaultIC secure element (for example the VaultIC 408). It offloads TLS ECC P-256 sign, verify, keygen, and ECDH to the chip through wolfSSL's PK callbacks and loads the device and CA certificates stored on the chip, so the TLS private key never leaves the secure element. Only the glue is in-tree; it calls the external SealSQ VaultIC-TLS SDK.
What it adds
wolfcrypt/src/port/sealsq/vaultic.c+wolfssl/wolfcrypt/port/sealsq/vaultic.h:WOLFSSL_VAULTIC_EccSignCb/EccVerifyCb/EccKeyGenCb/EccSharedSecretCb- P-256 ops on the deviceWOLFSSL_VAULTIC_LoadCertificates- read device + CA certs off the chipWOLFSSL_VAULTIC_SetupPkCallbacks/SetupPkCallbackCtx- register the callbackswolfcrypt/src/port/sealsq/README.md- build, usage, and provisioning notes.--enable-vaultic(definesWOLFSSL_VAULTIC, auto-enables PK callbacks); wiring mirrors theiotsafeport. Compiles to nothing when off../configure --enable-vaultic \ CFLAGS="-I/path/to/VaultIC-TLS/vaultic_tls-4xx/src" LIBS="-lvaultic_tls_408"Testing
--enable-vaulticconfigures and compiles cleanly against the vendor SDK header.ECDHE_ECDSA/SECP256R1) and TLS 1.3 (SecP256r1MLKEM768) handshakes complete, with sign, verify, keygen, and ECDH dispatched to the chip and certificates loaded off the device.