Skip to content

TFM bounds checks for safety #10964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SparkiDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TFM bounds checks for safety #10964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions wolfcrypt/src/tfm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3969,6 +3969,10 @@ int fp_to_unsigned_bin_len(fp_int *a, unsigned char *b, int c)
int j = 0;
int x;

if (c < 0) {
return FP_VAL;
}

for (x=c-1; x >= 0 && i < a->used; x--) {
b[x] = (unsigned char)(a->dp[i] >> j);
j += 8;
Expand All @@ -3990,6 +3994,10 @@ int fp_to_unsigned_bin_len(fp_int *a, unsigned char *b, int c)
int x;
WC_DECLARE_VAR(t, fp_int, 1, 0);

if (c < 0) {
return FP_VAL;
}

WC_ALLOC_VAR_EX(t, fp_int, 1, NULL, DYNAMIC_TYPE_BIGINT, return FP_MEM);

fp_init_copy(t, a);
Expand Down Expand Up @@ -4071,7 +4079,7 @@ int fp_is_bit_set (fp_int *a, fp_digit b)
{
fp_digit i;

if (b > FP_MAX_BITS)
if (b >= FP_MAX_BITS)
return FP_VAL;

i = b/DIGIT_BIT;
Expand All @@ -4087,7 +4095,7 @@ int fp_set_bit (fp_int * a, fp_digit b)
{
fp_digit i;

if (b > FP_MAX_BITS)
if (b >= FP_MAX_BITS)
return FP_VAL;

i = b/DIGIT_BIT;
Expand Down
Loading