Add crypto callback only mode for curve25519#10832
Merged
Merged
Conversation
padelsbach
force-pushed
the
curve25519-cryptocb-only
branch
from
July 6, 2026 15:36
b8fc923 to
d4e2e43
Compare
padelsbach
marked this pull request as ready for review
July 6, 2026 15:39
|
retest this please |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10832
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
|
@padelsbach CI failing |
Contributor
Author
|
jenkins retest this please |
Contributor
|
Jenkis retest this please. |
Frauschi
previously approved these changes
Jul 8, 2026
padelsbach
force-pushed
the
curve25519-cryptocb-only
branch
2 times, most recently
from
July 13, 2026 16:20
3007402 to
dafbb48
Compare
4 tasks
padelsbach
force-pushed
the
curve25519-cryptocb-only
branch
from
July 17, 2026 18:18
dafbb48 to
57655e0
Compare
Contributor
Author
|
@rizlik, can you take a look at this one now that ed25519 has merged? |
padelsbach
force-pushed
the
curve25519-cryptocb-only
branch
from
July 20, 2026 14:34
61854dd to
4c7cbf5
Compare
4 tasks
bigbrett
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion PR to #10830. Applied for
make_keyandshared_secretoperations. No streaming or async support.Note: some fe_operations math routines linger due to some curve25519 operations without
CRYPTO_CBsupport (regular or "only" mode). About 6kB of code can be trimmed in CB-only mode. I'm considering that as a follow-up change. GE math is fully trimmed however.Testing
Added unit tests
Checklist