Crypto layer: Add missing input validation by lealem47 · Pull Request #10819 · wolfSSL/wolfssl

lealem47 · 2026-06-30T16:31:30Z

Description

commit 1 - Adding miscellaneous input validation throughout wolfcrypt files.
commit 2 - Appendix A in SP800-38b recommends a minimum CMAC tag length of 64-bits
commit 3 - Synchronizes user-space and kernel-space builds so that similar FIPS versions and build settings will default to the same WOLFSSL_MIN_AUTH_TAG_SZ

Testing

./configure --enable-all && make check

Checklist

added tests
updated/added doxygen
updated appropriate READMEs
Updated manual and documentation

Copilot

Pull request overview

This PR hardens wolfCrypt/wolfSSL by adding additional input validation and tightening default Diffie–Hellman parameter minimums to align with modern security guidance (2048-bit minimum by default, overridable for legacy use).

Changes:

Introduces DH_MIN_SIZE (default 2048 bits) and aligns TLS-layer DH minimums with the DH primitive’s minimum.
Adds/adjusts input validation to prevent overflow/wraparound and invalid arguments in KDF/PRF, ECC key import, RSA key generation, and DH operations.
Updates an existing DH test to be conditionally compiled based on DH_MIN_SIZE.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
wolfssl/wolfcrypt/settings.h	Defines `DH_MIN_SIZE` with a secure default and legacy override mapping.
wolfssl/version.h	Updates library version macros (currently inconsistent with rest of repo).
wolfssl/internal.h	Aligns `WOLFSSL_MIN_DHKEY_BITS` default with `DH_MIN_SIZE` and enforces consistency.
wolfcrypt/src/rsa.c	Fixes heap usage in an OAEP error path and tightens RSA exponent validation under FIPS.
wolfcrypt/src/kdf.c	Adds null/length argument validation and prevents `word32` wraparound in length checks.
wolfcrypt/src/ecc.c	Prevents potential `word32` overflow when expanding compressed ECC point lengths.
wolfcrypt/src/dh.c	Rejects DH primes smaller than `DH_MIN_SIZE` and adds a null check in `wc_DhCheckPubValue`.
tests/api/test_dh.c	Gates a subgroup-check test on `DH_MIN_SIZE` (affects coverage in default builds).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-06-30T16:36:32Z

MemBrowse Memory Report

gcc-arm-cortex-m0plus

FLASH: .text +468 B (+0.7%, 64,675 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m3

FLASH: .text +404 B (+0.3%, 122,943 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4

FLASH: .text +384 B (+0.2%, 201,173 B / 262,144 B, total: 77% used)

gcc-arm-cortex-m4-baremetal

FLASH: .text +448 B (+0.7%, 67,275 B / 262,144 B, total: 26% used)

gcc-arm-cortex-m4-crypto-only

FLASH: .text +128 B (+0.1%, 175,120 B / 262,144 B, total: 67% used)

gcc-arm-cortex-m4-dtls13

FLASH: .text +384 B (+0.2%, 181,412 B / 1,048,576 B, total: 17% used)

gcc-arm-cortex-m4-min-ecc

FLASH: .text +448 B (+0.7%, 62,189 B / 262,144 B, total: 24% used)

gcc-arm-cortex-m4-openssl-compat

FLASH: .text +128 B (+0.0%, 769,340 B / 1,048,576 B, total: 73% used)

gcc-arm-cortex-m4-pkcs7

FLASH: .text +448 B (+0.2%, 213,844 B / 262,144 B, total: 82% used)

gcc-arm-cortex-m4-pq

FLASH: .text +384 B (+0.1%, 280,384 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m4-rsa-only

FLASH: .text +128 B (+0.0%, 326,040 B / 1,048,576 B, total: 31% used)

gcc-arm-cortex-m4-sp-math

FLASH: .text +448 B (+0.7%, 62,189 B / 262,144 B, total: 24% used)

gcc-arm-cortex-m4-tls12

FLASH: .text +448 B (+0.4%, 123,739 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4-tls13

FLASH: .text +384 B (+0.2%, 237,063 B / 262,144 B, total: 90% used)

gcc-arm-cortex-m7

FLASH: .text +384 B (+0.2%, 201,173 B / 262,144 B, total: 77% used)

gcc-arm-cortex-m7-pq

FLASH: .text +384 B (+0.1%, 280,960 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m7-tls13

FLASH: .text +384 B (+0.2%, 237,127 B / 262,144 B, total: 90% used)
No memory changes detected for:
linuxkm-pie
linuxkm-standard
stm32-sim-stm32h753

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

lealem47 · 2026-06-30T21:23:08Z

Jenkins Retest this please

Frauschi · 2026-07-01T15:40:14Z

@lealem47 PRB-master-job failures are legit.

Frauschi · 2026-07-02T08:09:00Z

Jenkins retest this please

Frauschi

🐺 Skoll Code Review

Overall recommendation: APPROVE
Findings: 2 total — 2 posted, 0 skipped

Posted findings

[Low] FIPS RSA exponent floor reuses WC_RSA_EXPONENT default macro — wolfcrypt/src/rsa.c:5415-5419
[Info] Non-conforming indentation in wc_PRF NULL-argument check — wolfcrypt/src/kdf.c:92-94

Review generated by Skoll via Claude/Codex

Frauschi · 2026-07-21T09:04:07Z

Jenkins retest this please.

Frauschi

🐺 Skoll Code Review

Overall recommendation: APPROVE
Findings: 3 total — 2 posted, 2 skipped

Posted findings

[Medium] WOLFSSL_MIN_AUTH_TAG_SZ clamp moved from kernel-only to all builds silently overrides explicit user values — wolfssl/wolfcrypt/settings.h:3895-3919 (removed from 4275-4424 WOLFSSL_LINUXKM block)
[Info] Indentation of new wc_PRF NULL check does not match wolfSSL 4-space style — wolfcrypt/src/kdf.c:92-94

Skipped findings

[Low] CMAC minimum tag size raised 4->8 changes accepted tag range for existing callers
[Medium] WOLFSSL_MIN_AUTH_TAG_SZ clamp moved from kernel-only to all builds silently overrides explicit user values

Review generated by Skoll via Claude/Codex

lealem47 · 2026-07-23T00:07:57Z

Jenkins Retest this please.

…user-space build

…pdate

Frauschi · 2026-07-23T06:42:59Z

Jenkins retest this please

lealem47 · 2026-07-24T00:01:19Z

Jenkins Retest this please

lealem47 self-assigned this Jun 30, 2026

Copilot AI review requested due to automatic review settings June 30, 2026 16:31

Copilot started reviewing on behalf of lealem47 June 30, 2026 16:32 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread wolfssl/version.h Outdated

Comment thread tests/api/test_dh.c

lealem47 force-pushed the input_validation branch from c66cde1 to 8961b60 Compare June 30, 2026 16:56

lealem47 requested a review from Copilot June 30, 2026 16:59

Copilot started reviewing on behalf of lealem47 June 30, 2026 17:00 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread wolfcrypt/src/ecc.c Outdated

Comment thread wolfcrypt/src/kdf.c

Comment thread wolfcrypt/src/kdf.c

lealem47 assigned wolfSSL-Bot and unassigned lealem47 Jun 30, 2026

lealem47 force-pushed the input_validation branch from cb5d209 to 69af8ed Compare July 1, 2026 00:39

Frauschi assigned lealem47 and unassigned wolfSSL-Bot Jul 1, 2026

lealem47 force-pushed the input_validation branch 2 times, most recently from b465f15 to 7a1e0ca Compare July 1, 2026 23:04

Frauschi reviewed Jul 2, 2026

View reviewed changes

Comment thread wolfcrypt/src/rsa.c

Comment thread wolfcrypt/src/kdf.c Outdated

lealem47 force-pushed the input_validation branch from 7a1e0ca to 6c96a72 Compare July 20, 2026 22:59

lealem47 requested a review from Frauschi July 20, 2026 23:23

lealem47 assigned Frauschi and wolfSSL-Bot and unassigned lealem47 Jul 20, 2026

Frauschi reviewed Jul 21, 2026

View reviewed changes

Comment thread wolfcrypt/src/kdf.c

Frauschi assigned lealem47 and unassigned wolfSSL-Bot Jul 21, 2026

lealem47 force-pushed the input_validation branch from 362a269 to 48794a1 Compare July 21, 2026 13:59

lealem47 force-pushed the input_validation branch from 48794a1 to 1a7a536 Compare July 21, 2026 14:42

lealem47 added 5 commits July 22, 2026 21:27

Crypto layer: Add missing input validation

3bae119

Increase WC_CMAC_TAG_MIN_SZ to SP800-38b recommendation

460d5d0

Remove MIN_AUTH_TAG_SZ logic from kernel section to synchronize with …

4851d26

…user-space build

Fix spacing nit

cd6b282

Testing touch-ups to account for error code fix and MIN_AUTH_TAG_SZ u…

8a51b31

…pdate

lealem47 force-pushed the input_validation branch from 1a7a536 to 8a51b31 Compare July 23, 2026 03:27

Uh oh!

Conversation

lealem47 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lealem47 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frauschi commented Jul 1, 2026

Uh oh!

Frauschi commented Jul 2, 2026

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

Uh oh!

Frauschi commented Jul 21, 2026 • edited by lealem47 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings

Uh oh!

Uh oh!

lealem47 commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frauschi commented Jul 23, 2026

Uh oh!

lealem47 commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lealem47 commented Jun 30, 2026 •

edited

Loading

github-actions Bot commented Jun 30, 2026 •

edited

Loading

lealem47 commented Jun 30, 2026 •

edited

Loading

Frauschi commented Jul 21, 2026 •

edited by lealem47

Loading

lealem47 commented Jul 23, 2026 •

edited

Loading

lealem47 commented Jul 24, 2026 •

edited

Loading