Skip to content

Xilinx Versal Gen2 ASU port: TRNG, hashes, HMAC offload#10765

Merged
JacobBarthelmeh merged 2 commits into
wolfSSL:masterfrom
night1rider:Xilinx-ASU-TRNG-Hashes-HMAC
Jul 22, 2026
Merged

Xilinx Versal Gen2 ASU port: TRNG, hashes, HMAC offload#10765
JacobBarthelmeh merged 2 commits into
wolfSSL:masterfrom
night1rider:Xilinx-ASU-TRNG-Hashes-HMAC

Conversation

@night1rider

@night1rider night1rider commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Initial porting for Xilinx Versal Gen 2 ASU support, will need #10750

@night1rider night1rider self-assigned this Jun 23, 2026
@dgarske
dgarske self-requested a review June 23, 2026 21:06
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jun 23, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from db2421e to aba9df7 Compare June 24, 2026 20:34
@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch 2 times, most recently from f309e78 to aa3bc31 Compare July 13, 2026 19:57
@night1rider
night1rider marked this pull request as ready for review July 13, 2026 20:25
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

retest this please

@github-actions

github-actions Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m3

  • FLASH: +14 B (+0.0%, 122,539 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4

  • FLASH: +14 B (+0.0%, 200,789 B / 262,144 B, total: 77% used)

gcc-arm-cortex-m4-dtls13

  • FLASH: .rodata +12 B, .text +64 B (+0.0%, 181,028 B / 1,048,576 B, total: 17% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .rodata +96 B, .text -2,624 B (-0.3%, 769,212 B / 1,048,576 B, total: 73% used)
  • RAM: .bss +192 B (+0.1%, 136,936 B / 262,144 B, total: 52% used)

gcc-arm-cortex-m4-pkcs7

  • FLASH: .text +256 B (+0.1%, 213,396 B / 262,144 B, total: 81% used)

gcc-arm-cortex-m4-pq

  • FLASH: .rodata +16 B, .text +64 B (+0.0%, 280,000 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .rodata +8 B, .text +192 B (+0.1%, 325,912 B / 1,048,576 B, total: 31% used)

gcc-arm-cortex-m4-tls12

  • FLASH: +14 B (+0.0%, 123,291 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4-tls13

  • FLASH: .text +64 B (+0.0%, 236,679 B / 262,144 B, total: 90% used)

gcc-arm-cortex-m7

  • FLASH: +14 B (+0.0%, 200,789 B / 262,144 B, total: 77% used)

gcc-arm-cortex-m7-pq

  • FLASH: .rodata +16 B, .text +64 B (+0.0%, 280,576 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m7-tls13

  • FLASH: .text +64 B (+0.0%, 236,743 B / 262,144 B, total: 90% used)

linuxkm-pie

  • Data: __patchable_function_entries -8 B (-0.0%, 25,960 B)

linuxkm-standard

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 13, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from aa3bc31 to 995d981 Compare July 14, 2026 07:18
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 14, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch 2 times, most recently from 744e5e9 to 42a1bc2 Compare July 14, 2026 18:46
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 14, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from 42a1bc2 to 69ca335 Compare July 14, 2026 19:40
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 14, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from 69ca335 to dc0567a Compare July 14, 2026 21:08
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 14, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from dc0567a to b7a795d Compare July 15, 2026 00:44
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 15, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from b7a795d to fb7b82d Compare July 15, 2026 02:23
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 15, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from fb7b82d to 7412a46 Compare July 15, 2026 03:44
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 15, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from 7412a46 to 2c4c55f Compare July 15, 2026 04:58
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 15, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10765

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

JacobBarthelmeh
JacobBarthelmeh reviewed Jul 16, 2026
View reviewed changes
Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_rng.c
Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_util.c Outdated
Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_util.c
@night1rider
night1rider force-pushed the Xilinx-ASU-TRNG-Hashes-HMAC branch from 99ec678 to 66f6f7c Compare July 20, 2026 23:05
JacobBarthelmeh
JacobBarthelmeh requested changes Jul 21, 2026
View reviewed changes

@JacobBarthelmeh JacobBarthelmeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions! Please resolve the remaining CI tests before this can be merged.

@JacobBarthelmeh JacobBarthelmeh removed their assignment Jul 21, 2026
@night1rider

night1rider commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

jenkins retest this please

@night1rider
versal_gen2_asu: fix check-source-text native heap false positive and…
64c7699 
… add port macros to .wolfssl_known_macro_extras.
@JacobBarthelmeh
JacobBarthelmeh merged commit 1cfa98a into wolfSSL:master Jul 22, 2026
342 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments
@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes
@dgarske dgarske Awaiting requested review from dgarske

Assignees

@JacobBarthelmeh JacobBarthelmeh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@night1rider @JacobBarthelmeh @wolfSSL-Fenrir-bot