Fix: hpke return code improvements#10455
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Standardizes HPKE error handling by replacing legacy -1 returns with a defined error code (BAD_FUNC_ARG) for unsupported/default switch cases (including X448 fallthrough paths), aligning with the project’s error-code conventions.
Changes:
- Replace
ret = -1;withret = BAD_FUNC_ARG;in four HPKE switchdefaultbranches. - Ensures consistent, defined error codes are returned from serialize/deserialize and encap/decap paths when the KEM/curve is not handled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
Author
|
Jenkins retest this please. |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10455
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
SparkiDev
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Four switch cases returned -1 rather than a defined error code. Updated all of them (and the X448 fallthrough cases) to return
BAD_FUNC_ARG.X448 isn't supported for HPKE right now, hence the fallthrough.
Fixes F-1908
Checklist