LMS: fixes and improvements#10448
Merged
Merged
Conversation
|
Remove WC_LMS_PARM_NONE as it serves no purpose. Change sig_len from a 16-bit value to a 32-bit value in the parameters. Added wc_LmsKey_SetParameters_ex() and wc_LmsKey_GetParameters_ex() to handle hash algorithm. Change mass ForceZeros to smaller amounts with XMEMSET and setting to NULL or default valus. Allow signing of empty message. Other minor fixes. Fix API tests to work when WOLFSSL_LMS_MAX_HEIGHT/WOLFSSL_LMS_MAX_LEVELS are/is defined.
Contributor
Author
|
Jenkins: retest this please |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10448
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-rs-src, wolfcrypt-src
No new issues found in the changed files. ✅
Frauschi
approved these changes
May 12, 2026
dgarske
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove WC_LMS_PARM_NONE as it serves no purpose.
Change sig_len from a 16-bit value to a 32-bit value in the parameters. Added wc_LmsKey_SetParameters_ex() and wc_LmsKey_GetParameters_ex() to handle hash algorithm.
Change mass ForceZeros to smaller amounts with XMEMSET and setting to NULL or default valus.
Allow signing of empty message.
Other minor fixes.
Fix API tests to work when WOLFSSL_LMS_MAX_HEIGHT/WOLFSSL_LMS_MAX_LEVELS are/is defined.
Testing
Regression tested LMS.