Increase hostap retry count#10389
Merged
Merged
Conversation
|
julek-wolfssl
requested changes
May 4, 2026
julek-wolfssl
left a comment
julek-wolfssl
left a comment
Member
There was a problem hiding this comment.
As is the action will never fail. You don't actually do anything with the HWSIM_RES value.
julek-wolfssl
requested changes
May 4, 2026
julek-wolfssl
left a comment
julek-wolfssl
left a comment
Member
There was a problem hiding this comment.
As is the action will never fail. You don't actually do anything with the HWSIM_RES value.
Contributor
Author
|
PR updated. Test now fails if none of the tries succeed. |
julek-wolfssl
previously approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the hostap VM GitHub Actions workflow to reduce CI flakiness by retrying failed upstream hostap test cases before failing the job.
Changes:
- Add up to 2 retries for failed
vm/parallel-vm.pytest runs. - Replace the prior single re-run behavior with explicit retry logic and a hard failure if tests still fail after retries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Fixed the Copilot findings. |
dgarske
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry hostap tests up to 2 times to reduce flakyness.