Implementation for PEM_write_PrivateKey & PEM_write_PUBKEY#10317
Merged
Conversation
Contributor
Author
|
@julek-wolfssl could you run the workflow on this ? |
|
Can one of the admins verify this patch? |
Member
|
Okay to test. Contributor agreement on file. |
|
Roy-Carter
force-pushed
the
feature/pem_write_enhancement
branch
from
April 29, 2026 10:05
a5506d0 to
4f700a4
Compare
Contributor
Author
|
same here , vpn test failed , rebased to master @julek-wolfssl |
Member
|
Jenkins retest this please |
dgarske
approved these changes
May 5, 2026
Member
|
Hi @Roy-Carter can you please rebase this to latest master and force push again? Thank you! |
Roy-Carter
force-pushed
the
feature/pem_write_enhancement
branch
from
May 8, 2026 14:55
4f700a4 to
517f05e
Compare
Contributor
Author
|
hey @dgarske , just rebased it to master , wanna re-run workflow just incase? |
dgarske
requested changes
May 8, 2026
Contributor
Author
|
@dgarske Fixed the header guard for the function , can we re-run ? |
Member
|
Jenkins retest this please |
Member
|
Jenkins retest this please |
julek-wolfssl
requested changes
May 20, 2026
julek-wolfssl
left a comment
julek-wolfssl
left a comment
Member
There was a problem hiding this comment.
Please fix this error. Please rebase before pushing.
Testing DEFAULT: --enable-leantls --enable-session-ticket --enable-sni --enable-opensslextra --disable-shared
Configure RESULT = 0
make[2]: warning: -j3 forced in submake: resetting jobserver mode.
In file included from src/ssl.c:459:
./src/pk.c:306:12: error: ‘der_write_to_file_as_pem’ defined but not used [-Werror=unused-function]
306 | static int der_write_to_file_as_pem(const unsigned char* der, int derSz,
| ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
julek-wolfssl
assigned
Roy-Carter and unassigned
dgarske,
wolfSSL-Bot and
julek-wolfssl
Roy-Carter
force-pushed
the
feature/pem_write_enhancement
branch
from
May 22, 2026 16:25
511b36a to
b20c1db
Compare
Contributor
Author
|
I've fixed the notes and rebased to master , can we re-run workflow @julek-wolfssl ? |
julek-wolfssl
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of a continuous integration from OpenSSL I came across the missing functions of : PEM_write_PrivateKey & PEM_write_PUBKEY while their read does exist , i've reversed the logic based on the read implementation to also support compatibility for write .
Testing
Tested via adding 2 new tests
Checklist