Skip to content

Zero DH keys, tighten SSL APIs, harden TLS extensions#10304

Merged
dgarske merged 5 commits into
wolfSSL:masterfrom
JeremiahM37:fenrir-2
May 7, 2026
Merged

Zero DH keys, tighten SSL APIs, harden TLS extensions#10304
dgarske merged 5 commits into
wolfSSL:masterfrom
JeremiahM37:fenrir-2

Conversation

@JeremiahM37

@JeremiahM37 JeremiahM37 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Fixes F-2085, F-2083, F-2888, F-2889, F-2104, F-2108, F-2106, F-2901, F-3228, F-2934, F-1836, F-1840, F-2935, F-2936

Zeroize DH private keys on free

  • TLSX_KeyShare_FreeAll: zero FFDHE privKey
  • wolfSSL_DH_generate_key: zero priv
  • FreeKeyExchange: zero sig.buffer
  • Sniffer async free: zero SnifferKey

Guard zero length in DES ncbc

  • wolfSSL_DES_ncbc_encrypt: early-return on length <= 0

Harden SSL config and session

  • wolfSSL_clear: restore PSK DHE flags from ctx
  • wolfSSL_SetSession: skip state on expired session
  • set_default_verify_paths: fail closed when no CA source
  • parse_cipher_list: fail on TLS 1.3-only list, non-1.3 ctx

Harden TLS extension processing

  • TLSX_CA_Names_GetSize: cap at WOLFSSL_MAX_16BIT
  • TLSX_ECH parse: enforce allowed msgTypes
  • TLSX_USE_SRTP parse: enforce allowed msgTypes

@JeremiahM37 JeremiahM37 self-assigned this Apr 24, 2026
@JeremiahM37
JeremiahM37 force-pushed the fenrir-2 branch 2 times, most recently from 7c9bb61 to 15c4881 Compare April 24, 2026 18:39

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10304

Scan targets checked: wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@github-actions

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@JeremiahM37

Copy link
Copy Markdown
Contributor Author

Jenkins retest this please

@dgarske

dgarske commented May 5, 2026

Copy link
Copy Markdown
Member

@JeremiahM37 please resolve merge conflicts. Thanks

@JeremiahM37
JeremiahM37 force-pushed the fenrir-2 branch 2 times, most recently from 024b88d to 10ef2af Compare May 5, 2026 21:13
@JeremiahM37

Copy link
Copy Markdown
Contributor Author

Jenkins retest this please

@JeremiahM37 JeremiahM37 removed their assignment May 7, 2026
@dgarske
dgarske merged commit bf6c870 into wolfSSL:master May 7, 2026
442 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants