Add Negative Testing and Zeroization#10155
Merged
Merged
Conversation
dgarske
reviewed
Apr 9, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 2 total — 2 posted, 0 skipped
Posted findings
- [Low] Missing wc_AsconAEAD128_Clear after negative decrypt in API test —
tests/api/test_ascon.c:212-213 - [Low] SRP negative test corrupts proof but also uses mismatched session key —
wolfcrypt/test/test.c:27678-27728
Review generated by Skoll via openclaw
Contributor
|
retest this please |
Member
|
Jenkins retest this please |
dgarske
approved these changes
May 5, 2026
Member
|
@aidangarske please squash and also remove the hyperlinks to Fenrir in commits and description. Thanks |
aidangarske
force-pushed
the
fenrir-fixes-2
branch
from
May 7, 2026 17:38
6528eb3 to
bf03de6
Compare
|
dgarske
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
F-2192— Add negative test for AES-SIV authentication tag verificationF-2193— Add negative test for ASCON AEAD128 authentication tag verificationF-2194— Add negative test for AES Key Unwrap IV verificationF-2202— Add negative test for SRP VerifyPeersProof authentication checkF-2203— Add negative test for ECC ECIES HMAC authentication tag verificationF-2207— Add ForceZero of ECC private key before free in PKCS#11F-2208— Add ForceZero of RSA private exponent before free in Xilinx path