Fix issues addressed by static analysis#967
Merged
ejohnstown merged 3 commits intowolfSSL:masterfrom May 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses a few static-analysis findings by tightening error handling in MAC verification, removing a stray/incorrect assignment in OpenSSH key parsing, and fixing CSI cursor-position handling in the Windows terminal code path.
Changes:
- Ensure
VerifyMac()only performs the constant-time MAC comparison when HMAC computation succeeded, preserving the underlying HMAC error on failure. - Remove an incorrect
idx = 0;assignment inGetOpenSshKey()’s private-key parsing path. - Fix CSI
Hcursor positioning to treat 0/omitted row/column arguments as1before applying the Linux(1,1) ↔ Windows(0,0) offset.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/wolfterm.c |
Fixes CSI H cursor move argument defaults to avoid unsigned underflow and to align with expected terminal semantics. |
src/internal.c |
Fixes static-analysis issues in OpenSSH key parsing and MAC verification error handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following minor issues:
Addressed by f_520, f_521 and f_522