Skip to content

Fix fwTPM response buffer overflow, SPDM clear-frame command bypass, and other misc hardening - #561

Merged
dgarske merged 25 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-7263-7285
Jul 29, 2026
Merged

Fix fwTPM response buffer overflow, SPDM clear-frame command bypass, and other misc hardening#561
dgarske merged 25 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-7263-7285

Conversation

@aidangarske

@aidangarske aidangarske commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member 
F-7026, F-7260, F-7261, F-7263, F-7264, F-7265, F-7266, F-7267, F-7268,
F-7269, F-7270, F-7271, F-7272, F-7273, F-7274, F-7275, F-7276, F-7277, 
F-7279, F-7280, F-7281, F-7282, F-7283, F-7284, F-7285

Copilot AI review requested due to automatic review settings July 27, 2026 22:16
Copilot AI reviewed Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aidangarske
aidangarske force-pushed the fenrir-fixes-7263-7285 branch 2 times, most recently from 36c0023 to efd8154 Compare July 27, 2026 22:43
@aidangarske
aidangarske marked this pull request as ready for review July 27, 2026 22:57
@aidangarske
aidangarske requested a review from dgarske July 27, 2026 22:58
@aidangarske aidangarske self-assigned this Jul 27, 2026
@aidangarske
aidangarske force-pushed the fenrir-fixes-7263-7285 branch from efd8154 to d2370b9 Compare July 28, 2026 15:32
dgarske
dgarske requested changes Jul 28, 2026
View reviewed changes
Comment thread src/fwtpm/fwtpm_command.c Outdated
Comment thread src/fwtpm/fwtpm_command.c
Comment thread src/fwtpm/fwtpm_main.c Outdated
Comment thread src/fwtpm/fwtpm_main.c
Comment thread src/tpm2_asn.c
Comment thread wolftpm/tpm2_packet.h Outdated
@dgarske dgarske removed their assignment Jul 28, 2026
aidangarske added 18 commits July 28, 2026 18:41
@aidangarske
F-7272 - Honor caller response buffer capacity in FWTPM_ProcessCommand
247853b
@aidangarske
F-7277 - Return TPM_RC_TYPE for an unrecognized TestParms public type
4803578
@aidangarske
F-7276 - Validate classical public parameters in TestParms
4f695f3
@aidangarske
F-7264 - Mask with RC_MAX_FMT1 when testing for TPM_RC_CURVE
ab1ba32
@aidangarske
F-7266 - Mask with RC_MAX_FMT1 in bench unsupported-symmetric check
0e93f85
@aidangarske
F-7269 - Skip ML-DSA verify when the sign section produced no signature
e938dac
@aidangarske
F-7026 - Set error code when public key buffer allocation fails in quote
51cad3b
@aidangarske
F-7271 - Compare NV index type with equality instead of bitwise AND
916b937
@aidangarske
F-7273 - Reject secured-only vendor commands arriving in SPDM clear f…
a860221 
…rames
@aidangarske
F-7280 - Zeroize WOLFTPM2_DEV before returning it to the heap
0b9debd
@aidangarske
F-7279 - Scrub the shared command buffer during TPM2_Cleanup
6bae2bc
@aidangarske
F-7265 - Remove dead short-response guard in SPDM swtpm IO callback
9707322
@aidangarske
F-7268 - Fail GET_PUBK when the responder public key exceeds the cont…
e7345cb 
…ext buffer
@aidangarske
F-7274 - Guard block round-up against wrap in hash update cache
c2fa5c0
@aidangarske
F-7267 - Bound the PSS padding block against the caller stack buffer
494e505
@aidangarske
F-7285 - Scrub the PSS stack hash context after freeing it
e76f186
@aidangarske
F-7283 - Scrub the NV index auth from the NVCreate compatibility wrapper
a317475
@aidangarske
F-7284 - Scrub the hashed input copy in wolfTPM2_HashUpdate
da1cb8c
@aidangarske
aidangarske force-pushed the fenrir-fixes-7263-7285 branch from d2370b9 to 32e3a65 Compare July 29, 2026 01:41
@aidangarske
aidangarske force-pushed the fenrir-fixes-7263-7285 branch from 32e3a65 to 6cbf2d1 Compare July 29, 2026 01:49
@aidangarske
aidangarske requested a review from dgarske July 29, 2026 01:52
@dgarske
dgarske merged commit 3e95d5f into wolfSSL:master Jul 29, 2026
199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@dgarske dgarske dgarske approved these changes

Assignees

@dgarske dgarske

@aidangarske aidangarske

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidangarske @dgarske