always set continueSession in password auth response for fwtpm - #530
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses TPM 2.0 password-authorization response semantics in the fwTPM implementation (Fixes #529) by ensuring the response sessionAttributes indicates continueSession for TPM_RS_PW (password) authorizations, matching TPM 2.0 Part 1 §16.4 expectations and improving interoperability with clients like go-tpm.
Changes:
- Force-set
TPMA_SESSION_continueSessionin the response auth area when the command uses a password authorization (TPM_RS_PW). - Add a fwTPM unit test that issues a
PCR_Extendwith a password auth session whose command attributes byte is0x00, and asserts the response hascontinueSessionset.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/fwtpm/fwtpm_command.c |
Adjusts password-session response auth-area attribute handling to set continueSession. |
tests/fwtpm_unit_tests.c |
Adds a regression test validating continueSession is set in password-session responses. |
dgarske
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #529