Add bounds check on KRB5KDF constant length to prevent buffer overflow#421
Merged
padelsbach merged 1 commit intoJul 1, 2026
Merged
Conversation
padelsbach
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wp_kdf_krb5kdf_derivepassesctx->constantSzton_fold, which doesXMEMCPY(block, constant, constant_len)into the fixed 16-byte stack bufferblock[AES_BLOCK_SIZE]. A constant longer than the block size overflows the stack (and triggers asize_tunderflow in a laterXMEMSET).n_fold's documented precondition requiresconstant_len <= blocksize, but the caller never enforced an upper bound. OpenSSL's KRB5KDF guards against this; we now do too.Changes
src/wp_krb5kdf.c: rejectconstantSz > AES_BLOCK_SIZEbefore callingn_fold.test/test_krb5kdf.c: negative test with an oversized constant; runs against both wolfProvider and OpenSSL (both must reject).Testing
Full suite passes;
test_krb5kdfconfirms both providers reject the oversized constant.Fixes fenrir F-4076