Fixes from Fenrir review#420
Merged
Merged
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #420
Scan targets checked: wolfprovider-bugs, wolfprovider-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
F-2216, F-2217, F-2218, F-2221 wp_drbg.c - wp_drbg_generate, addInLen is now checked and a debug message sent. - Added prediction resistance when WP_AHVE_DRBG_RESEED. wp_pbkdf2.c - PBKDF2 check all parameters when required - PKCS12 Match behaviour of OpenSSL when deriving and iterations is 0 - do 1 iteration - test added for non-FIPS
SparkiDev
force-pushed
the
fenrir_fixes_1
branch
from
June 30, 2026 07:42
4cb7509 to
38e4479
Compare
ColtonWilley
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-2216, F-2217, F-2218, F-2221
wp_drbg.c
wp_pbkdf2.c