Implement locking around signature operations#172
Merged
Conversation
…ate multithreaded flows with multiple threads sharing an underlying key.
padelsbach
reviewed
Jun 16, 2025
padelsbach
reviewed
Jun 17, 2025
padelsbach
previously approved these changes
Jun 17, 2025
Contributor
|
Do all private key operations need to be locked? |
padelsbach
approved these changes
Jun 19, 2025
Contributor
Author
I did iterative testing on bind9, only with RSA, ECC, and ECX locked did we get no errors. I was also surprised. |
Contributor
Author
|
Retest this please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement locking around wolfProvider signature operations to facilitate multithreaded flows with multiple threads sharing an underlying key. Designed to fix issues presented in bind9 multithreaded use case.