Skip to content

Fix increments for void pointers#431

Merged
padelsbach merged 1 commit into
wolfSSL:mainfrom
kojiws:fix_void_pointer_increment
Jul 1, 2026
Merged

Fix increments for void pointers#431
padelsbach merged 1 commit into
wolfSSL:mainfrom
kojiws:fix_void_pointer_increment

Conversation

@kojiws

@kojiws kojiws commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add -Wpointer-arith to CFLAGS_EXTRA in test/Makefile to catch void pointer arithmetic at build time.
  • Fix void pointer arithmetic in src/wh_server_crypto.c and src/wh_server_keystore.c.

Test

  • cd test && make clean && make WOLFSSL_DIR=<WOLFSSL_DIR> run
  • cd test && make clean && make DMA=1 ASAN=1 WOLFSSL_DIR=<WOLFSSL_DIR> run

@kojiws
kojiws marked this pull request as draft June 29, 2026 09:00
@kojiws
kojiws force-pushed the fix_void_pointer_increment branch from 59ef5ec to b2e5253 Compare June 29, 2026 09:31
@kojiws
kojiws marked this pull request as ready for review June 29, 2026 09:32
@kojiws

kojiws commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

This PR needs rebase after #428 or #429 has been merged because the base main branch of this PR has problem with tests.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #431

Scan targets checked: wolfhsm-core-bugs, wolfhsm-crypto-bugs, wolfhsm-src

No new issues found in the changed files. ✅

@kojiws
kojiws force-pushed the fix_void_pointer_increment branch from b2e5253 to 7373917 Compare June 30, 2026 13:55
@kojiws kojiws assigned kojiws and wolfSSL-Bot and unassigned kojiws Jun 30, 2026
@padelsbach
padelsbach merged commit b338f98 into wolfSSL:main Jul 1, 2026
108 checks passed
@kojiws
kojiws deleted the fix_void_pointer_increment branch July 2, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants