Skip to content

Add refactored SHE tests#399

Merged
AlexLanzano merged 1 commit into
wolfSSL:mainfrom
padelsbach:test-refactor-add-she
Jun 24, 2026
Merged

Add refactored SHE tests#399
AlexLanzano merged 1 commit into
wolfSSL:mainfrom
padelsbach:test-refactor-add-she

Conversation

@padelsbach

Copy link
Copy Markdown
Contributor

Notes:

  • Server SHE checks use the common whServerContext* instead of setup/teardown of each server
  • The 3 client-server tests are merged into whTest_she since secure-boot cannot be re-run on the persistent server
  • Identical coverage in source files wh_she.c

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #399

No scan targets match the changed files in this PR. Review skipped.

@padelsbach
padelsbach force-pushed the test-refactor-add-she branch from 17dde3b to 6c959e9 Compare June 3, 2026 19:50
@padelsbach

Copy link
Copy Markdown
Contributor Author

This change uncovered the issue fixed in #401 and this PR includes that fix.

@padelsbach
padelsbach marked this pull request as ready for review June 4, 2026 16:49
@AlexLanzano

Copy link
Copy Markdown
Member

@padelsbach Please resolve the merge conflicts when you can. Thanks

@bigbrett bigbrett removed their assignment Jun 9, 2026
bigbrett
bigbrett previously approved these changes Jun 9, 2026

@bigbrett bigbrett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go to me once you resolve merge conflicts @padelsbach

@padelsbach

Copy link
Copy Markdown
Contributor Author

rebased to resolve conflicts

@padelsbach padelsbach assigned bigbrett and unassigned padelsbach Jun 15, 2026
@padelsbach
padelsbach force-pushed the test-refactor-add-she branch from a86f770 to d7e183d Compare June 22, 2026 21:37
@padelsbach padelsbach assigned AlexLanzano and unassigned bigbrett Jun 22, 2026
@padelsbach
padelsbach requested a review from AlexLanzano June 22, 2026 21:39
@padelsbach

Copy link
Copy Markdown
Contributor Author

Sending over to @AlexLanzano while Brett is out

@AlexLanzano
AlexLanzano merged commit 24d8d2b into wolfSSL:main Jun 24, 2026
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants