Add refactored crypto tests#355
Conversation
3d82ef0 to
5702deb
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #355
No scan targets match the changed files in this PR. Review skipped.
5702deb to
243a219
Compare
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
@padelsbach realizing we need a way to iterate over devIds for the DMA-capable algos. Any ideas for how to do this cleanly? Look at how we currently do it in crypto tests with the global devIds array - that solution is def janky but there are some logical groupings of crypto tests that should be run identically just with multiple devIds.
Do we group these on a per-algo level? That way the high level test function signatures remain the same, but then the cmac test (for example) would internally run its core logic for every devId in a loop?
44a3a5c to
e84d260
Compare
e84d260 to
f30527e
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #355
No scan targets match the changed files in this PR. Review skipped.
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
@padelsbach looks good.
Just for tracking, this is largely incomplete as we still need coverage of RSA async, CMAC async + DMA-async, Curve25519 SharedSecretCacheKey, ECC SharedSecretCacheKey, ML-DSA 65/87 and ML-KEM in its entirety.
4 participants
No description provided.