Skip to content

Fix Memory leak in CMAC DMA code #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Frauschi wants to merge 1 commit into from
Closed

Fix Memory leak in CMAC DMA code #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ tools/testcertgen/*.der
*.code-workspace
.vscode
compile_commands.json
**/.cache

# Static analysis
tools/static-analysis/reports/
Expand Down
8 changes: 6 additions & 2 deletions src/wh_client_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3838,8 +3838,12 @@ int wh_Client_CmacDma(whClientContext* ctx, Cmac* cmac, CmacType type,
/* If this is just a deferred initialization (NULL key, but keyId set),
* don't send a request - server will initialize on first update */
if ((key == NULL) && (in == NULL) && (outMac == NULL)) {
/* Just a keyId set operation, nothing to do via DMA */
return 0;
/* Just a keyId set operation, nothing to do via DMA except for
* cleanup of the state buffer */
(void)wh_Client_DmaProcessClientAddress(
ctx, (uintptr_t)cmac, (void**)&stateAddr, req->state.sz,
WH_DMA_OPER_CLIENT_WRITE_POST, (whDmaFlags){0});
return WH_ERROR_OK;
}

if (ret == WH_ERROR_OK) {
Expand Down