Conversation
bigbrett
requested changes
Dec 2, 2025
bigbrett
left a comment
bigbrett
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good. 3 things:
- Please run git-clang-format main
- Please rename the test-local keys from
eccPublicandeccPrivateto justaliceKeyandbobKeyor something like that. Calling them private and public is a misnomer - both keys contain public and private ECC points. I know you didn't write this original code but might as well do this change now. - Please squash commits into 1 single commit
bigbrett
requested changes
Dec 10, 2025
bigbrett
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly expands and refines the ECC (Elliptic Curve Cryptography) test coverage in
whTest_CryptoEccwithintest/wh_test_crypto.c. The changes introduce multiple new ECC test cases that cover ephemeral, exported, and cached server-side keys, and improve the clarity of test output messages for easier debugging and validation.