Skip to content

Minor adjustment to RNG free in test case and null check in TCP getter function #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigbrett merged 2 commits into from
Nov 3, 2025
Merged

Minor adjustment to RNG free in test case and null check in TCP getter function #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ec7538
fix for checking on if RNG was init'd in test before free'ing it
JacobBarthelmeh Nov 3, 2025
0816fc1
null check on TCP fd parameter before set
JacobBarthelmeh Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion port/posix/posix_transport_tcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ int posixTransportTcp_GetConnectFd(posixTransportTcpClientContext *context,
case PTT_STATE_CONNECT_WAIT:
case PTT_STATE_CONNECTED:
ret = WH_ERROR_OK;
if (*out_fd) {
if (out_fd) {
*out_fd = context->connect_fd_p1 - 1;
}
break;
Expand Down
8 changes: 7 additions & 1 deletion test/wh_test_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3734,6 +3734,7 @@ int whTestCrypto_MlDsaVerifyOnlyDma(whClientContext* ctx, int devId,
int whTest_CryptoClientConfig(whClientConfig* config)
{
int i;
int rngInited = 0;
whClientContext client[1] = {0};
int ret = 0;
/* wolfcrypt */
Expand Down Expand Up @@ -3775,6 +3776,9 @@ int whTest_CryptoClientConfig(whClientConfig* config)
if (ret != 0) {
WH_ERROR_PRINT("Failed to reinitialize RNG %d\n", ret);
}
else {
rngInited = 1;
}
}

if (ret == 0) {
Expand Down Expand Up @@ -3935,7 +3939,9 @@ int whTest_CryptoClientConfig(whClientConfig* config)
#endif /* WOLFHSM_CFG_TEST_VERBOSE */

/* Clean up used resources */
(void)wc_FreeRng(rng);
if (rngInited) {
(void)wc_FreeRng(rng);
}
(void)wh_Client_CommClose(client);
(void)wh_Client_Cleanup(client);

Expand Down