Fix f_640, f_641, f_642, f_643#210
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses input normalization and parameter selection in the CLI tooling, fixing two issues where uppercasing previously had no effect and correcting XMSS^MT parameter strings used for key generation.
Changes:
- Store the result of
toupper()back into the curve name buffer for ECC-related options (genkey, ecparam). - Fix XMSS^MT parameter string construction for specific
-height/-layercombinations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/genkey/clu_genkey_setup.c | Fixes curve-name uppercasing and corrects XMSS^MT parameter strings for certain layer defaults. |
| src/ecparam/clu_ecparam.c | Fixes curve-name uppercasing for -name handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes: