Fix path concatenation in wolfCLU_CertSignAppendOut#197
Merged
Conversation
kojo1
changed the title
dgarske
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both
new_certs_dir(from config file) and-outoption arespecified in the
cacommand, the output paths were incorrectlyconcatenated.
Bug example:
Config:
new_certs_dir = /tmp/certsCommand:
wolfssl ca -config ca.conf -out /tmp/output/signed.pem ...Result:
/tmp/certs/tmp/output/signed.pem(wrong)Expected:
/tmp/output/signed.pemRoot Cause
In
wolfCLU_CertSignAppendOut()(src/x509/clu_x509_sign.c), when appendingthe
-outpath tonew_certs_dir:Absolute paths in
-outwere not detected and should overridenew_certs_dirPath separator
/was missing when concatenating directory and filename