Improve x509-req-test.sh#188
Merged
Merged
Conversation
JacobBarthelmeh
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the
x509-req-test.shnot to keep wrong error status unintentionally, after an error happens.The script will add configurations to
test-prompt.confandtest.confwhile running.Once the script stopped in the middle, those files are un-removed, and wrong configuration file which has duplicated contents will be generated at next run.
This PR changes from "add" to "create" for the configuration files.
Test
wolfSSL v5.8.2:
./configure --enable-wolfclu && make install
wolfCLU:
./configure && make check