fix: support benchmark competition type

[zacjones93]

Summary

• recognize the stored benchmark competition type across the schema and capability registry
• show benchmark on organizer edit forms while keeping it unavailable during generic creation
• widen dependent WODsmith and Crew type contracts and document the behavior

Investigation

The demo row comp_training_guide_benchmark already stores competition_type = benchmark. The blank picker was a missing application codepath; this PR does not mutate demo data.

Verification

• pnpm test -- test/lib/competitions/capabilities.test.ts --bail=1
• pnpm type-check in apps/wodsmith-start
• pnpm type-check in packages/wodsmith-db
• pnpm type-check in apps/crew
• browser verification against the demo PlanetScale branch as admin@example.com
• lat check

---

Summary by cubic

Adds first-class support for the benchmark competition type and tightens type contracts so create only accepts selectable types while update accepts any registered type. Benchmark stays editable on organizer pages, uses the standard leaderboard, fails closed for capability gates, and remains hidden from generic creation.

• Capabilities and registry: add benchmark to COMPETITION_TYPE_REGISTRY with no capabilities and standard leaderboard; add isCompetitionTypeValue; expose competitionTypeOptions() (all types) and selectableCompetitionTypeOptions() (create-only); keep unknown types safe in competitionCan, leaderboardVariant, and isSelectableType.
• Forms and server: organizer edit switches to competitionTypeOptions() and validates with isCompetitionTypeValue; create flow validates with isSelectableCompetitionTypeValue and hard-guards selectable types before submit; server schemas use SelectableCompetitionTypeId for create and CompetitionTypeId + isCompetitionTypeValue for update.
• Types and schema: replace "in-person" | "online" with CompetitionType across sidebars, leaderboard, judge scheduling, and Crew rotations; widen DB to CompetitionType and add COMPETITION_TYPES.BENCHMARK; no data migration.
• Tests: pin benchmark and unknown-type fallback behavior; assert benchmark is registered but not create-selectable; add type-level check that SelectableCompetitionTypeId is "in-person" | "online".

Migration

• Replace any "in-person" | "online" narrowings with CompetitionType; use SelectableCompetitionTypeId for create paths.

^{Written for commit 51448e6. Summary will update on new commits.}

Summary by CodeRabbit

• New Features

  • Added support for the Benchmark competition type for perpetual tracking.
  • Existing benchmark competitions can be edited and retained.
  • Competition type pickers now distinguish between types available for creation and types supported for editing.
  • Added clearer competition type descriptions and validation.

• Documentation

  • Updated organizer and capability documentation to describe benchmark behavior and availability.

• Tests

  • Expanded coverage for benchmark metadata, validation, picker options, and capability rules.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b97c8a1a-6153-49f9-a955-8deb6a3d9e58

📥 Commits

Reviewing files that changed from the base of the PR and between 8362e3d and c529055.

📒 Files selected for processing (14)

• apps/crew/src/server/crew-judge-rotations.server.ts
• apps/wodsmith-start/src/components/cohost-sidebar.tsx
• apps/wodsmith-start/src/components/competition-sidebar.tsx
• apps/wodsmith-start/src/components/leaderboard-page-content.tsx
• apps/wodsmith-start/src/lib/competitions/capabilities.ts
• apps/wodsmith-start/src/routes/compete/organizer/$competitionId/-components/judges/judge-scheduling-container.tsx
• apps/wodsmith-start/src/routes/compete/organizer/$competitionId/-components/organizer-competition-edit-form.tsx
• apps/wodsmith-start/src/server-fns/check-in-fns.ts
• apps/wodsmith-start/src/server-fns/competition-fns.ts
• apps/wodsmith-start/src/server-fns/competition-server-logic.ts
• apps/wodsmith-start/test/lib/competitions/capabilities.test.ts
• lat.md/competition-type-capabilities.md
• lat.md/organizer-dashboard.md
• packages/wodsmith-db/src/schemas/competitions.ts

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.

---

Walkthrough

The change adds benchmark to the shared competition type model and registry. It updates capability validation, picker options, organizer editing, server schemas, application contracts, tests, and documentation.

Changes

Competition type support

Layer / File(s)	Summary
Shared type contracts packages/wodsmith-db/src/schemas/competitions.ts, apps/crew/..., apps/wodsmith-start/src/components/*, apps/wodsmith-start/src/server-fns/*	The shared CompetitionType now includes benchmark. Application contracts replace duplicated literal unions.
Registry and validation apps/wodsmith-start/src/lib/competitions/capabilities.ts	The registry defines benchmark metadata, validates unknown values, applies explicit defaults, and generates picker options.
Organizer editing and server flow apps/wodsmith-start/src/routes/compete/organizer/..., apps/wodsmith-start/src/server-fns/competition-fns.ts	Editing accepts registered types and derives descriptions from option metadata. Creation remains limited to selectable types.
Tests and documentation apps/wodsmith-start/test/lib/competitions/capabilities.test.ts, lat.md/*	Tests and documentation cover benchmark capabilities, registered options, unknown values, and edit-form behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to c5290

The PR adds support for the stored benchmark competition type and exposes it only where intended; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• wodsmith/thewodapp#197: Establishes the related competition type and organizer form changes.
• wodsmith/thewodapp#563: Also modifies the capability registry for benchmark.
• wodsmith/thewodapp#613: Relates to shared CompetitionType and registry handling.

Suggested reviewers: theianjones

Poem

I’m a rabbit reviewing types in a row,
Benchmark now has a place to go.
The registry guards each option bright,
Unknown values fail closed and right.
Forms and tests follow the trail—
I wiggle my nose and approve the tale.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 27.27% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding support for the benchmark competition type.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/benchmark-competition-type

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

All reported issues were addressed across 14 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>